Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP diagnostic is too long if the current window is so narrow #1953

Closed
Zaplae opened this issue Apr 4, 2022 · 7 comments · Fixed by #6417
Closed

LSP diagnostic is too long if the current window is so narrow #1953

Zaplae opened this issue Apr 4, 2022 · 7 comments · Fixed by #6417
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@Zaplae
Copy link

Zaplae commented Apr 4, 2022

image

When the diagnostic displays:

image

@Zaplae
Copy link
Author

Zaplae commented Apr 4, 2022

Could it be hidden automatically?

@kirawi kirawi added C-enhancement Category: Improvements A-helix-term Area: Helix term improvements labels Apr 4, 2022
@lukepighetti
Copy link

Just ran into this myself. It's very difficult to read the LSP diagnostic. Would be nice if there was a background or border applied to it

Without LSP diagnostic

Screen Shot 2022-04-26 at 2 46 52 PM

With LSP diagnostic

Screen Shot 2022-04-26 at 2 46 58 PM

@NoraPerry
Copy link

+1 for some kind of border or coloured background. Depending on the color theme it can be impossible to distinguish where the file contents ends and the diagnostic starts.

@0rphee
Copy link
Contributor

0rphee commented Jul 11, 2022

I'd love to have a popup window similar to the one from "Space mode".
Screen Shot 2022-07-11 at 5 35 58 p m
Screen Shot 2022-07-11 at 5 33 54 p m

@jakenvac
Copy link
Contributor

I'm not sure this should be labelled enhancement - I would consider that the diagnostics rendering over code to be a bug. Especially so when the code you're trying to fix is obscured by the message.

@gabydd
Copy link
Member

gabydd commented Dec 16, 2022

Honestly I think this is the best issue: #1462 (not labelled bug but it could be)

@pascalkuthe
Copy link
Member

It's labeled an enhancement because the code behaves as intended, it's just that other UI options might yield better results. This is sort of an edgecase in terms of labelling but the label won't change the way this issue is treated so it doesn't matter too much.

I closed all other issues except this one and #1462.
#1462 is specifically about intrusive diagnostics so I think it made sense to keep one separate issue to also explore alternative solutions like a popup mentinoed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants