Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scroll_down command at the end of a file #4219

Closed
aleksanderkrauze opened this issue Oct 12, 2022 · 2 comments
Closed

Support scroll_down command at the end of a file #4219

aleksanderkrauze opened this issue Oct 12, 2022 · 2 comments
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@aleksanderkrauze
Copy link

In contrast to vim's <C-e> in helix scroll_down will stop when the end of the file is reached. This makes moving the end of a file higher in the terminal not possible using this method. I know that it can be done using align_view_top, but this requires changing one motion to another.

I propose aligning helix's behavior to vim's. I will try providing a PR for that.

@aleksanderkrauze aleksanderkrauze added the C-enhancement Category: Improvements label Oct 12, 2022
@the-mikedavis the-mikedavis added the A-helix-term Area: Helix term improvements label Oct 12, 2022
@pascalkuthe
Copy link
Member

Tgis was accidentialmy fixed by #5420 but #6966 is about restoring that behavior so we have two conflicting issues now. We should either decide to keep the current behavior or decide to fix #6966. Slightly leaning towards keeping the current behavior for simplicity. You can always scroll back up.

@pascalkuthe
Copy link
Member

Pl we decided to keep this so this was fixing by #5420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

3 participants