Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands that prompt for a key do not work properly when run from the command palette #9690

Open
totallyuniquelily opened this issue Feb 21, 2024 · 1 comment
Labels
A-command Area: Commands C-bug Category: This is a bug E-hard Call for participation: Experience needed to fix: Hard / a lot

Comments

@totallyuniquelily
Copy link

totallyuniquelily commented Feb 21, 2024

Summary

select_register does not work properly when selected from the command palette.

Commands that prompt for a key do not work properly when ran from the command palette.

For example, if you run select_register the popup showing the registers will appear, but pressing a key to select the register instead executes the command bound to it.

Reproduction Steps

I tried this:

  1. hx
  2. space + ?
  3. select register, and enter
  4. type in a key (e.g. m)

I expected this to happen:

  • the select register popup appears
  • the selected register is changed to m.
    (or an error is shown if using the command from the command palette is unintended)

Instead, this happened:

  • the select register popup properly (?) appears
  • minor match mode gets activated

Helix log

No response

Platform

Void Linux

Terminal Emulator

konsole-23.08.4_1

Installation Method

xbps (distro package manager). confirmed with source

Helix Version

23.10 (also confirmed on master)

@totallyuniquelily totallyuniquelily added the C-bug Category: This is a bug label Feb 21, 2024
@totallyuniquelily totallyuniquelily changed the title select_register not working from the command palette commands that prompt for a key do not work properly when run from the command palette Feb 21, 2024
@the-mikedavis
Copy link
Member

Also see #4508. Ideally the command palette should not be executing commands itself but rather queueing up commands to be handled through the normal codepaths. It requires a very large refactor to fix this though

@the-mikedavis the-mikedavis added E-hard Call for participation: Experience needed to fix: Hard / a lot A-command Area: Commands labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-command Area: Commands C-bug Category: This is a bug E-hard Call for participation: Experience needed to fix: Hard / a lot
Projects
None yet
Development

No branches or pull requests

2 participants