feat: improve hx fish completion #10853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yuntaz0
commented
May 30, 2024
yuntaz0
commented
- add -w and --working-dir options
- shorten option description
- dynamically call hx --health
- add -w and --working-dir options - shorten option description - dynamically call hx --health
markstos
approved these changes
May 31, 2024
contrib/completion/hx.fish
Outdated
| complete -c hx -s w -l working-dir -d "Specify initial working directory" -xa "(__fish_complete_directories)" | ||
|
|
||
| function __hx_langs_ops | ||
| hx --health | tail -n '+7' | awk '{print $1}' | sed 's/\x1b\[[0-9;]*m//g' |
There was a problem hiding this comment.
I believe this chain needs some work too. The +7 is too small - it was probably correct at the time but we have added more information to the --health output since. It could use hx --health languages and chop off the header instead.
Since --health now shows multiple language servers this also includes some check or x characters that should be removed
- remove header - remove check/x characters
|
screenshot of Fish completing |
the-mikedavis
approved these changes
Jul 6, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* feat: improve hx fish completion - add -w and --working-dir options - shorten option description - dynamically call hx --health * feat: improve health check completion - remove header - remove check/x characters * feat: use hx --health languages in completion
mxxntype
pushed a commit
to mxxntype/helix
that referenced
this pull request
Aug 14, 2024
* feat: improve hx fish completion - add -w and --working-dir options - shorten option description - dynamically call hx --health * feat: improve health check completion - remove header - remove check/x characters * feat: use hx --health languages in completion
kyruzic
pushed a commit
to kyruzic/helix
that referenced
this pull request
Sep 27, 2024
* feat: improve hx fish completion - add -w and --working-dir options - shorten option description - dynamically call hx --health * feat: improve health check completion - remove header - remove check/x characters * feat: use hx --health languages in completion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.