Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basedpyright langserver #11121

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Add basedpyright langserver #11121

merged 1 commit into from
Jul 10, 2024

Conversation

baiyang1919813
Copy link
Contributor

No description provided.

@the-mikedavis the-mikedavis added the A-language-support Area: Support for programming/text languages label Jul 10, 2024
@David-Else
Copy link
Contributor

This language server seems controversial if we are to believe the author of pyright: microsoft/pyright#8065 (comment). I don't have an opinion, but I think whoever approves this PR should have a quick look at the thread.

@the-mikedavis
Copy link
Member

IMO the controversy isn't relevant. An editor having configuration for a language server doesn't imply any sort of favor for it or opinion about it - it's just compatibility. For example we have a default configuration for intelephense even though it's closed source and paid. (Not at all the same situation but sort of a similar idea)

Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not removing pyright in favor of this kne. Just havng both servers in the config allows users to use whatever they prefer which I think isn't controversial.

I am also well acquainted with pyrights issues. LSP in general has the issue of being vscode centric but pyright in particular has been a continously source of problems with little interest from maintainers to improve. I certainly understand where this fork is coming from.

@pascalkuthe pascalkuthe merged commit 649bd45 into helix-editor:master Jul 10, 2024
6 checks passed
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@baiyang1919813 baiyang1919813 deleted the patch-1 branch July 11, 2024 03:23
mxxntype pushed a commit to mxxntype/helix that referenced this pull request Aug 14, 2024
kyruzic pushed a commit to kyruzic/helix that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants