Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bogster theme improvements #11353

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

href
Copy link
Contributor

@href href commented Jul 28, 2024

This add two features that have not been added to Bogster from what I can tell:

Here's a before / after view for the jump labels:

Before After
Alacritty-2024-07-28-lcCG9dyQ Alacritty-2024-07-28-WEU4MrWs

And here's a before after view for the primary selection highlight:

Before After
Alacritty-2024-07-28-Ak5ErFFx Alacritty-2024-07-28-E1g8x9jt

I hope this is sufficient as far as PRs go, I've been using these tweaks since 24.03, and I'm finally getting around to upstreaming them.

@the-mikedavis
Copy link
Member

\cc @vv9k what do you think of the changes?

@the-mikedavis the-mikedavis added the A-theme Area: Theme and appearence related label Jul 28, 2024
@archseer
Copy link
Member

archseer commented Aug 9, 2024

I find the jump label a bit jarring perhaps? But it's up to the theme author

@RossSmyth
Copy link
Contributor

My two cents as a Bogster daily driver:

  1. I agree with the yellow being jarring. My opinion is just the bold modifier & a light bg is good.

image

  1. I think base2 is too faint for a selection. Playing around making the primary selection base4 and the rest base3 I personally find better.

image

But it is up to the theme author, as these are already in my config.

@kirawi
Copy link
Member

kirawi commented Aug 20, 2024

The author of the theme was last active on GitHub a little over a year ago. I think it might be fine to proceed?

@archseer archseer merged commit d103248 into helix-editor:master Sep 30, 2024
6 checks passed
plul pushed a commit to plul/helix that referenced this pull request Oct 13, 2024
* Add a distinct jump-label to bogster theme

* Make the primary label visible in the bogster theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants