router: fix prometheus metrics high cardinality issue #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #448 Refers to [CVE(internal)](https://github.com/helm/chartmuseum/security/advisories/GHSA-67g5-8r7h-h9qv) Signed-off-by: scbizu <scbizu@gmail.com>
scbizu
force-pushed
the
fix/high-high-cardinality
branch
2 times, most recently
from
ce3a8f2
to
f81ffa4
Compare
scbizu
force-pushed
the
fix/high-high-cardinality
branch
from
f81ffa4
to
9e3de5b
Compare
Signed-off-by: scbizu <scbizu@gmail.com>
Signed-off-by: scbizu <scbizu@gmail.com>
cbuto
approved these changes
Sep 30, 2024
| @@ -1,30 +1,29 @@ | |||
| module helm.sh/chartmuseum | |||
|
|
|||
| go 1.21 | |||
| go 1.23 | |||
There was a problem hiding this comment.
I had to set this to build 🤔
Suggested change
| go 1.23 | |
| go 1.23.0 |
or
Suggested change
| go 1.23 | |
| go 1.23 | |
| toolchain go1.23.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Possibly high cardinality on chartmuseum_requests_total labels #448
Refers to CVE(internal)