This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/grafana] Support multiple types of dashboard provisioning #15770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
Contribution Allowed
helm-bot
added
the
size/XS
|
Hi @irasnyd. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
|
/ok-to-test can you ptal? |
k8s-ci-robot
added
ok-to-test
and removed
needs-ok-to-test
zanhsieh
reviewed
Jul 23, 2019
|
@irasnd may you can include your suggestion #15725 (comment) inside the same PR ? |
helm-bot
added
Contribution Allowed
Ok, I have added another commit which adds this fix. |
added 3 commits
July 23, 2019 09:46
Support both the "standard" method of dashboard provisioning and the "sidecar" method of dashboard provisioning within this Helm chart, at the same time. The Grafana chart currently supports both methods of automated dashboard provisioning, however both methods are not supported at the same time. This is a limitation of the Helm chart, which has been lifted by this commit. Signed-off-by: Ira W. Snyder <isnyder@lco.global>
Dashboard provisioning has been broken since stable/grafana 3.5.6. See Issue #15725. This commit fixes dashobard provisioning. Signed-off-by: Ira W. Snyder <isnyder@lco.global>
As requested by PR review comments. Signed-off-by: Ira W. Snyder <isnyder@lco.global>
zanhsieh
approved these changes
Jul 24, 2019
|
/test all |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irasnyd, zanhsieh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Thanks ! :-D |
ThoTischner
pushed a commit
to bitsbeats/charts
that referenced
this pull request
Aug 13, 2019
…lm#15770) * Support multiple types of dashboard provisioning Support both the "standard" method of dashboard provisioning and the "sidecar" method of dashboard provisioning within this Helm chart, at the same time. The Grafana chart currently supports both methods of automated dashboard provisioning, however both methods are not supported at the same time. This is a limitation of the Helm chart, which has been lifted by this commit. Signed-off-by: Ira W. Snyder <isnyder@lco.global> * Fix dashboard provisioning Dashboard provisioning has been broken since stable/grafana 3.5.6. See Issue helm#15725. This commit fixes dashobard provisioning. Signed-off-by: Ira W. Snyder <isnyder@lco.global> * Update chart version As requested by PR review comments. Signed-off-by: Ira W. Snyder <isnyder@lco.global>
landorg
pushed a commit
to landorg/charts
that referenced
this pull request
Aug 19, 2019
…lm#15770) * Support multiple types of dashboard provisioning Support both the "standard" method of dashboard provisioning and the "sidecar" method of dashboard provisioning within this Helm chart, at the same time. The Grafana chart currently supports both methods of automated dashboard provisioning, however both methods are not supported at the same time. This is a limitation of the Helm chart, which has been lifted by this commit. Signed-off-by: Ira W. Snyder <isnyder@lco.global> * Fix dashboard provisioning Dashboard provisioning has been broken since stable/grafana 3.5.6. See Issue helm#15725. This commit fixes dashobard provisioning. Signed-off-by: Ira W. Snyder <isnyder@lco.global> * Update chart version As requested by PR review comments. Signed-off-by: Ira W. Snyder <isnyder@lco.global> Signed-off-by: Roland Gritzer <gritzer.roland@gmail.com>
kengou
pushed a commit
to kengou/charts
that referenced
this pull request
Sep 18, 2019
…lm#15770) * Support multiple types of dashboard provisioning Support both the "standard" method of dashboard provisioning and the "sidecar" method of dashboard provisioning within this Helm chart, at the same time. The Grafana chart currently supports both methods of automated dashboard provisioning, however both methods are not supported at the same time. This is a limitation of the Helm chart, which has been lifted by this commit. Signed-off-by: Ira W. Snyder <isnyder@lco.global> * Fix dashboard provisioning Dashboard provisioning has been broken since stable/grafana 3.5.6. See Issue helm#15725. This commit fixes dashobard provisioning. Signed-off-by: Ira W. Snyder <isnyder@lco.global> * Update chart version As requested by PR review comments. Signed-off-by: Ira W. Snyder <isnyder@lco.global>
ramkumarvs
pushed a commit
to yugabyte/charts-helm-fork
that referenced
this pull request
Sep 30, 2019
…lm#15770) * Support multiple types of dashboard provisioning Support both the "standard" method of dashboard provisioning and the "sidecar" method of dashboard provisioning within this Helm chart, at the same time. The Grafana chart currently supports both methods of automated dashboard provisioning, however both methods are not supported at the same time. This is a limitation of the Helm chart, which has been lifted by this commit. Signed-off-by: Ira W. Snyder <isnyder@lco.global> * Fix dashboard provisioning Dashboard provisioning has been broken since stable/grafana 3.5.6. See Issue helm#15725. This commit fixes dashobard provisioning. Signed-off-by: Ira W. Snyder <isnyder@lco.global> * Update chart version As requested by PR review comments. Signed-off-by: Ira W. Snyder <isnyder@lco.global>
skuxy
added a commit
to skuxy/charts
that referenced
this pull request
Nov 27, 2019
provisioners optional Signed-off-by: Borna Skukan <skuxay@gmail.com>
4 tasks
skuxy
added a commit
to skuxy/charts
that referenced
this pull request
Nov 27, 2019
provisioners optional. Also bumped version and added entry to README. Signed-off-by: Borna Skukan <skuxay@gmail.com>
k8s-ci-robot
pushed a commit
that referenced
this pull request
Dec 6, 2019
…19177) * Trying to alleviate change introduced in #15770 by making multiple provisioners optional. Also bumped version and added entry to README. Signed-off-by: Borna Skukan <skuxay@gmail.com> * Further version bump Signed-off-by: Borna Skukan <skuxay@gmail.com> * Making default behaviour same as before Signed-off-by: Borna Skukan <skuxay@gmail.com>
WyriHaximus
pushed a commit
to WyriHaximus-labs/charts
that referenced
this pull request
Dec 14, 2019
…elm#19177) * Trying to alleviate change introduced in helm#15770 by making multiple provisioners optional. Also bumped version and added entry to README. Signed-off-by: Borna Skukan <skuxay@gmail.com> * Further version bump Signed-off-by: Borna Skukan <skuxay@gmail.com> * Making default behaviour same as before Signed-off-by: Borna Skukan <skuxay@gmail.com>
dargolith
pushed a commit
to dargolith/charts
that referenced
this pull request
Jan 10, 2020
…elm#19177) * Trying to alleviate change introduced in helm#15770 by making multiple provisioners optional. Also bumped version and added entry to README. Signed-off-by: Borna Skukan <skuxay@gmail.com> * Further version bump Signed-off-by: Borna Skukan <skuxay@gmail.com> * Making default behaviour same as before Signed-off-by: Borna Skukan <skuxay@gmail.com>
arturrez
pushed a commit
to arturrez/stable-charts
that referenced
this pull request
Jan 28, 2020
…elm#19177) * Trying to alleviate change introduced in helm#15770 by making multiple provisioners optional. Also bumped version and added entry to README. Signed-off-by: Borna Skukan <skuxay@gmail.com> * Further version bump Signed-off-by: Borna Skukan <skuxay@gmail.com> * Making default behaviour same as before Signed-off-by: Borna Skukan <skuxay@gmail.com> Signed-off-by: Artur <artur@upbound.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Support both the "standard" method of dashboard provisioning and the "sidecar" method of dashboard provisioning within this Helm chart, at the same time.
The Grafana chart currently supports both methods of automated dashboard provisioning, however both methods are not supported at the same time. This is a limitation of the Helm chart, which has been lifted by this commit.
This PR was created so that I can use the
stable/prometheus-operatorHelm chart, version 6.0.0 to deploy Grafana with Kubernetes monitoring dashboards. In addition to the dashboards which are part ofstable/prometheus-operator, I wish to have additional dashboards from the Official Grafana Dashboard Hub provisioned automatically. This commit lifts the Helm chart's restriction on doing both of these two types of dashboard provisioning at the same time.Which issue this PR fixes
No issue was created.
Special notes for your reviewer:
The automatic Grafana dashboard provisioning has been broken since
stable/grafanaversion 3.5.6. Please see Issue #15725 for further information. I have tested this change by usingstable/grafana3.7.0 with my proposed fix in #15725 (comment) and thestable/prometheus-operatorchart version 6.0.0.I have mentioned all maintainers listed in Chart.yaml, per the instructions in the PR template:
@zanhsieh
@rtluckie
@maorfr
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart])