Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/airflow] bug fix to make git sync work with branches other then master #19414

Merged
merged 4 commits into from
Dec 6, 2019
Merged

[stable/airflow] bug fix to make git sync work with branches other then master #19414

merged 4 commits into from
Dec 6, 2019

Conversation

hmike96
Copy link
Contributor

@hmike96 hmike96 commented Dec 5, 2019

Is this a new chart

No

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

This pull request is a fix for git sync which currently has a bug preventing it from working with branches that are not master.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @hmike96. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 5, 2019
@k8s-ci-robot k8s-ci-robot requested a review from maver1ck December 5, 2019 21:15
@hmike96
bug fix to make git sync work with branches other then master
353f892 
Signed-off-by: Hewitt, Mike <hmike1996@gmail.com>
@hmike96
remove not needed code
bee1db3 
Signed-off-by: Hewitt, Mike <hmike1996@gmail.com>
@hmike96
git sync will work without init now
c5beeb0 
Signed-off-by: Hewitt, Mike <hmike1996@gmail.com>
@hmike96
git sync will work without init now
10935ad 
Signed-off-by: Hewitt, Mike <hmike1996@gmail.com>
@hmike96 hmike96 force-pushed the feature/gitSyncFromDifferentBranchBugFix branch from af4362d to 10935ad Compare December 5, 2019 21:15
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Dec 5, 2019
@hmike96
Copy link
Contributor Author

hmike96 commented Dec 5, 2019

@gsemet

@gsemet
Copy link
Contributor

gsemet commented Dec 6, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gsemet, hmike96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Dec 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 301ad36 into helm:master Dec 6, 2019
WyriHaximus pushed a commit to WyriHaximus-labs/charts that referenced this pull request Dec 14, 2019
@hmike96 @WyriHaximus
[stable/airflow] bug fix to make git sync work with branches other th…
05fea4e 
…en master (helm#19414)

* bug fix to make git sync work with branches other then master

Signed-off-by: Hewitt, Mike <hmike1996@gmail.com>

* remove  not  needed code

Signed-off-by: Hewitt, Mike <hmike1996@gmail.com>

* git sync will work  without  init now

Signed-off-by: Hewitt, Mike <hmike1996@gmail.com>

* git sync will work  without  init now

Signed-off-by: Hewitt, Mike <hmike1996@gmail.com>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@hmike96 @dargolith
[stable/airflow] bug fix to make git sync work with branches other th…
6aa1b4d 
…en master (helm#19414)

* bug fix to make git sync work with branches other then master

Signed-off-by: Hewitt, Mike <hmike1996@gmail.com>

* remove  not  needed code

Signed-off-by: Hewitt, Mike <hmike1996@gmail.com>

* git sync will work  without  init now

Signed-off-by: Hewitt, Mike <hmike1996@gmail.com>

* git sync will work  without  init now

Signed-off-by: Hewitt, Mike <hmike1996@gmail.com>
arturrez pushed a commit to arturrez/stable-charts that referenced this pull request Jan 28, 2020
@hmike96
[stable/airflow] bug fix to make git sync work with branches other th…
c1663dd 
…en master (helm#19414)

* bug fix to make git sync work with branches other then master

Signed-off-by: Hewitt, Mike <hmike1996@gmail.com>

* remove  not  needed code

Signed-off-by: Hewitt, Mike <hmike1996@gmail.com>

* git sync will work  without  init now

Signed-off-by: Hewitt, Mike <hmike1996@gmail.com>

* git sync will work  without  init now

Signed-off-by: Hewitt, Mike <hmike1996@gmail.com>
Signed-off-by: Artur <artur@upbound.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maver1ck maver1ck Awaiting requested review from maver1ck

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[airflow stable/chart] git sync does not sync on non-master branch
4 participants
@hmike96 @k8s-ci-robot @gsemet @helm-bot