Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/home-assistant] Fixes typo in README #21504

Merged
merged 1 commit into from
Mar 18, 2020
Merged

[stable/home-assistant] Fixes typo in README #21504

merged 1 commit into from
Mar 18, 2020

Conversation

MathildeLeroi
Copy link
Contributor

Signed-off-by: Mathilde Leroi mathilde.leroi@gmail.com

What this PR does / why we need it:

It fixes a typo in the README

@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Mar 17, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 17, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @MathildeLeroi. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runningman84
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 17, 2020
@runningman84
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 18, 2020
@billimek
Copy link
Collaborator

Hi @MathildeLeroi can you please bump the chart version (probably to 0.12.4) in the Charts.yaml file, in order for linting to pass?

@MathildeLeroi
[stable/home-assistant] Fixes typo in README
68062c2 
Signed-off-by: Mathilde Leroi <mathilde.leroi@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2020
@MathildeLeroi
Copy link
Contributor Author

Hi @billimek, I just updated the PR accordingly

@billimek
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: billimek, MathildeLeroi, runningman84

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3271409 into helm:master Mar 18, 2020
fowlie pushed a commit to fowlie/charts that referenced this pull request Mar 20, 2020
@MathildeLeroi
[stable/home-assistant] Fixes typo in README (helm#21504)
67ab4e5 
Signed-off-by: Mathilde Leroi <mathilde.leroi@gmail.com>
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@MathildeLeroi
[stable/home-assistant] Fixes typo in README (helm#21504)
81f3d8e 
Signed-off-by: Mathilde Leroi <mathilde.leroi@gmail.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@MathildeLeroi @includerandom
[stable/home-assistant] Fixes typo in README (helm#21504)
60b0250 
Signed-off-by: Mathilde Leroi <mathilde.leroi@gmail.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@MathildeLeroi @li-adrienloiseau
[stable/home-assistant] Fixes typo in README (helm#21504)
8df356d 
Signed-off-by: Mathilde Leroi <mathilde.leroi@gmail.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@MathildeLeroi
[stable/home-assistant] Fixes typo in README (helm#21504)
8ca7f15 
Signed-off-by: Mathilde Leroi <mathilde.leroi@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@billimek billimek billimek approved these changes

@runningman84 runningman84 Awaiting requested review from runningman84

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MathildeLeroi @k8s-ci-robot @runningman84 @billimek @helm-bot