This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[incubator/sparkoperator] Use securitycontext from the chart values for the init and cleanup jobs too
#21539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jobs too Signed-off-by: Wout Maaskant <wout.maaskant@riskident.com>
helm-bot
added
the
size/S
|
Hi @scheleaap. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
Signed-off-by: Wout Maaskant <wout.maaskant@riskident.com>
helm-bot
added
the
Contribution Allowed
|
/assign @liyinan926 |
|
/lgtm |
k8s-ci-robot
added
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liyinan926, scheleaap, yuchaoran2011 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fowlie
pushed a commit
to fowlie/charts
that referenced
this pull request
Mar 20, 2020
… for the init and cleanup jobs too (helm#21539) * Use `securitycontext` from the chart values for the init and cleanup jobs too Signed-off-by: Wout Maaskant <wout.maaskant@riskident.com> * Bump version Signed-off-by: Wout Maaskant <wout.maaskant@riskident.com> Co-authored-by: Wout Maaskant <wout.maaskant@riskident.com>
irlevesque
pushed a commit
to quantopian/charts
that referenced
this pull request
Jul 13, 2020
… for the init and cleanup jobs too (helm#21539) * Use `securitycontext` from the chart values for the init and cleanup jobs too Signed-off-by: Wout Maaskant <wout.maaskant@riskident.com> * Bump version Signed-off-by: Wout Maaskant <wout.maaskant@riskident.com> Co-authored-by: Wout Maaskant <wout.maaskant@riskident.com>
includerandom
pushed a commit
to includerandom/helm_charts
that referenced
this pull request
Jul 19, 2020
… for the init and cleanup jobs too (helm#21539) * Use `securitycontext` from the chart values for the init and cleanup jobs too Signed-off-by: Wout Maaskant <wout.maaskant@riskident.com> * Bump version Signed-off-by: Wout Maaskant <wout.maaskant@riskident.com> Co-authored-by: Wout Maaskant <wout.maaskant@riskident.com>
li-adrienloiseau
pushed a commit
to li-adrienloiseau/charts
that referenced
this pull request
Jul 29, 2020
… for the init and cleanup jobs too (helm#21539) * Use `securitycontext` from the chart values for the init and cleanup jobs too Signed-off-by: Wout Maaskant <wout.maaskant@riskident.com> * Bump version Signed-off-by: Wout Maaskant <wout.maaskant@riskident.com> Co-authored-by: Wout Maaskant <wout.maaskant@riskident.com> Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh
pushed a commit
to mmingorance-dh/charts
that referenced
this pull request
Aug 28, 2020
… for the init and cleanup jobs too (helm#21539) * Use `securitycontext` from the chart values for the init and cleanup jobs too Signed-off-by: Wout Maaskant <wout.maaskant@riskident.com> * Bump version Signed-off-by: Wout Maaskant <wout.maaskant@riskident.com> Co-authored-by: Wout Maaskant <wout.maaskant@riskident.com> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No
What this PR does / why we need it:
The
securityContextvalue of the chart is not applied to the init and cleanup jobs that run when installing, upgrading or deleting the chart. If the cluster has special security requirements (e.g. does not allow containers that run as root), this will cause the jobs to fail.This PR applies
securityContextto the job containers as well.Checklist
[stable/mychartname])@yuchaoran2011 @liyinan926