Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/grafana] Add support for extraExposePorts #21547

Merged
merged 3 commits into from
Mar 20, 2020
Merged

[stable/grafana] Add support for extraExposePorts #21547

merged 3 commits into from
Mar 20, 2020

Conversation

inseinjee
Copy link
Contributor

@inseinjee inseinjee commented Mar 20, 2020 •
edited
Loading

Is this a new chart: no

What this PR does / why we need it:

exposing other service ports for sidecar containers.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@inseinjee
Add support for extraExposePorts
feef5de 
Signed-off-by: Insein Jee <inseinjee@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @inseinjee. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from zanhsieh March 20, 2020 07:25
@zanhsieh
Copy link
Collaborator

@inseinjee
Could bump the chart version to latest please? Thank you.

@zanhsieh
Copy link
Collaborator

/assign

@inseinjee
Bump the chart version(5.0.7 -> 5.0.8)
6fb2a8b 
Signed-off-by: Insein Jee <inseinjee@gmail.com>
Signed-off-by: inseinjee <inseinjee@gmail.com>
@inseinjee
Remove trailing spaces
df9d09e 
Signed-off-by: inseinjee <inseinjee@gmail.com>
@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 20, 2020
@zanhsieh
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inseinjee, zanhsieh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit b729ce7 into helm:master Mar 20, 2020
@replicated-ship replicated-ship bot mentioned this pull request Mar 20, 2020
Open
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@inseinjee
[stable/grafana] Add support for extraExposePorts (helm#21547)
561f19a 
* Add support for extraExposePorts

Signed-off-by: Insein Jee <inseinjee@gmail.com>

* Bump the chart version(5.0.7 -> 5.0.8)

Signed-off-by: Insein Jee <inseinjee@gmail.com>
Signed-off-by: inseinjee <inseinjee@gmail.com>

* Remove trailing spaces

Signed-off-by: inseinjee <inseinjee@gmail.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@inseinjee @includerandom
[stable/grafana] Add support for extraExposePorts (helm#21547)
6c2fa0f 
* Add support for extraExposePorts

Signed-off-by: Insein Jee <inseinjee@gmail.com>

* Bump the chart version(5.0.7 -> 5.0.8)

Signed-off-by: Insein Jee <inseinjee@gmail.com>
Signed-off-by: inseinjee <inseinjee@gmail.com>

* Remove trailing spaces

Signed-off-by: inseinjee <inseinjee@gmail.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@inseinjee @li-adrienloiseau
[stable/grafana] Add support for extraExposePorts (helm#21547)
f9097da 
* Add support for extraExposePorts

Signed-off-by: Insein Jee <inseinjee@gmail.com>

* Bump the chart version(5.0.7 -> 5.0.8)

Signed-off-by: Insein Jee <inseinjee@gmail.com>
Signed-off-by: inseinjee <inseinjee@gmail.com>

* Remove trailing spaces

Signed-off-by: inseinjee <inseinjee@gmail.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@inseinjee
[stable/grafana] Add support for extraExposePorts (helm#21547)
33ca1f9 
* Add support for extraExposePorts

Signed-off-by: Insein Jee <inseinjee@gmail.com>

* Bump the chart version(5.0.7 -> 5.0.8)

Signed-off-by: Insein Jee <inseinjee@gmail.com>
Signed-off-by: inseinjee <inseinjee@gmail.com>

* Remove trailing spaces

Signed-off-by: inseinjee <inseinjee@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanhsieh zanhsieh zanhsieh approved these changes

Assignees

@zanhsieh zanhsieh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@inseinjee @k8s-ci-robot @zanhsieh @helm-bot