Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/gocd] Update ingress doc #21560

Merged
merged 2 commits into from
Mar 23, 2020
Merged

[stable/gocd] Update ingress doc #21560

merged 2 commits into from
Mar 23, 2020

Conversation

varshavaradarajan
Copy link
Collaborator

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2020
@varshavaradarajan
Copy link
Collaborator Author

varshavaradarajan commented Mar 21, 2020 •
edited
Loading

@GaneshSPatil - GoCD agents outside of the cluster connect to the GoCD server through Ingress on port 80 and 443 (defaults) ?

@arvindsv
Copy link
Collaborator

Looks good to me. I'll let @GaneshSPatil approve it. I wonder if we should add a link to (or mention) the location within values.yaml that these annotations need to be added to. Maybe it will be clear that it is this?

@varshavaradarajan
Copy link
Collaborator Author

@arvindsv - thank you! Yeah, I'll make that change. Looks like there's

charts/stable/gocd/values.yaml

Line 157 in dc4e53a

tls:
to add too.

@varshavaradarajan
[stable/gocd] Add docs for ingress
21277f4 
Signed-off-by: Varsha Varadarajan <varshasvaradarajan@gmail.com>
@varshavaradarajan
[stable/gocd] Update changelog.
e5d0c74 
Signed-off-by: Varsha Varadarajan <varshasvaradarajan@gmail.com>
@varshavaradarajan
Copy link
Collaborator Author

varshavaradarajan commented Mar 21, 2020 •
edited
Loading

@GaneshSPatil , @arvindsv - um, one of you needs to add lgtm for this to get merged.

@arvindsv
Copy link
Collaborator

/lgtm :)

@arvindsv
Copy link
Collaborator

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arvindsv, varshavaradarajan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1663190 into helm:master Mar 23, 2020
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@varshavaradarajan
[stable/gocd] Update ingress doc (helm#21560)
bea99cb 
* [stable/gocd] Add docs for ingress

Signed-off-by: Varsha Varadarajan <varshasvaradarajan@gmail.com>

* [stable/gocd] Update changelog.

Signed-off-by: Varsha Varadarajan <varshasvaradarajan@gmail.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@varshavaradarajan @includerandom
[stable/gocd] Update ingress doc (helm#21560)
f21cdbf 
* [stable/gocd] Add docs for ingress

Signed-off-by: Varsha Varadarajan <varshasvaradarajan@gmail.com>

* [stable/gocd] Update changelog.

Signed-off-by: Varsha Varadarajan <varshasvaradarajan@gmail.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@varshavaradarajan @li-adrienloiseau
[stable/gocd] Update ingress doc (helm#21560)
13489d9 
* [stable/gocd] Add docs for ingress

Signed-off-by: Varsha Varadarajan <varshasvaradarajan@gmail.com>

* [stable/gocd] Update changelog.

Signed-off-by: Varsha Varadarajan <varshasvaradarajan@gmail.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@varshavaradarajan
[stable/gocd] Update ingress doc (helm#21560)
916f37e 
* [stable/gocd] Add docs for ingress

Signed-off-by: Varsha Varadarajan <varshasvaradarajan@gmail.com>

* [stable/gocd] Update changelog.

Signed-off-by: Varsha Varadarajan <varshasvaradarajan@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GaneshSPatil GaneshSPatil GaneshSPatil approved these changes

@arvindsv arvindsv Awaiting requested review from arvindsv

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@varshavaradarajan @arvindsv @k8s-ci-robot @GaneshSPatil @helm-bot