Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/cockroachdb]: Update version to v19.2.5 #21584

Merged
merged 1 commit into from
Mar 23, 2020
Merged

[stable/cockroachdb]: Update version to v19.2.5 #21584

merged 1 commit into from
Mar 23, 2020

Conversation

danhhz
Copy link
Contributor

@danhhz danhhz commented Mar 23, 2020

Signed-off-by: Daniel Harrison daniel.harrison@gmail.com

What this PR does / why we need it:

Updates the cockroachdb version to the latest stable version v19.2.4 -> 19.2.5

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 23, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @danhhz. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Daniel Harrison <daniel.harrison@gmail.com>
@danhhz
Copy link
Contributor Author

danhhz commented Mar 23, 2020

/assign @a-robinson

@a-robinson
Copy link
Collaborator

/ok-to-test
/lgtm
/approve

Hi Dan! For what it's worth more people than just me can approve changes here these days: https://github.com/helm/charts/blob/master/stable/cockroachdb/OWNERS

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-robinson, danhhz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 23, 2020
@danhhz
Copy link
Contributor Author

danhhz commented Mar 23, 2020

Hey hey Alex! The bot told me to route it to you, I assumed it was a rotating through the OWNERS or something. I thought it was odd and was going to ask if you wanted to be removed from the list. Even more odd is that the comment where it told me to do that was deleted. I thought I was going crazy for a second, but it was in my email thread.

This pull-request has been approved by: danhhz
To complete the pull request process, please assign a-robinson
You can assign the PR to them by writing /assign @a-robinson in a comment when ready.

Original comment link (now broken): #21584 (comment)

Looks like the test flaked. It had a similar one for 19.2.4 and we retested to get it merged. It'd be nice to fix the flake but I have zero idea where to start and I wouldn't have time to dig into it if I did. : - /

Lets see if this works again.

/retest

@k8s-ci-robot k8s-ci-robot merged commit 4d2c85a into helm:master Mar 23, 2020
@danhhz danhhz deleted the cockroachdb_19-2-5 branch March 23, 2020 19:54
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
Signed-off-by: Daniel Harrison <daniel.harrison@gmail.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
Signed-off-by: Daniel Harrison <daniel.harrison@gmail.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
Signed-off-by: Daniel Harrison <daniel.harrison@gmail.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
Signed-off-by: Daniel Harrison <daniel.harrison@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants