Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/mysql] add basic affinity support (#12054) #21858

Merged
merged 1 commit into from
Apr 15, 2020
Merged

[stable/mysql] add basic affinity support (#12054) #21858

merged 1 commit into from
Apr 15, 2020

Conversation

nielsn
Copy link
Contributor

@nielsn nielsn commented Apr 9, 2020

Signed-off-by: Niels Nuyttens niels.nuyttens@gmail.com

@olemarkus @viglesiasce

What this PR does / why we need it:

Add basic support for pod affinities. Currently only nodeSelector support is provided.

Which issue this PR fixes

*fixes #12054

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@nielsn
[stable/mysql] add basic affinity support (#12054)
77a6ffe 
Signed-off-by: Niels Nuyttens <niels.nuyttens@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 9, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @nielsn. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@olemarkus
Copy link
Contributor

Hi,

Thanks for the contribution. Could you explain the use-case for anti-affinity in this chart?

@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2020
@nielsn
Copy link
Contributor Author

nielsn commented Apr 15, 2020

Hey @olemarkus ,

my issue isn't really related to anti-affinity. We're trying to get our MySQL pod scheduled on certain nodes using the standard combination of taints + tolerations (reserve our node for a subset of pods) and affinities (make sure these pods use the reserved node).

Our affinity is specified using annotations added by GKE (node pool information). Since the current MySQL chart didn't seem to support affinity, I had to add a specific label to all nodes in the desired node pool in order to use the nodeSelector. Nothing wrong there, but I would like to use the same mechanism for all of our scheduling.

Hence my very humble pull request. Does that clarify our case?

@olemarkus
Copy link
Contributor

Learnt something new today. Thanks :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nielsn, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 69fd281 into helm:master Apr 15, 2020
@nielsn nielsn deleted the 12054-mysql-affinities branch April 15, 2020 12:47
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@nielsn
[stable/mysql] add basic affinity support (helm#12054) (helm#21858)
a64aef2 
Signed-off-by: Niels Nuyttens <niels.nuyttens@gmail.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@nielsn @includerandom
[stable/mysql] add basic affinity support (helm#12054) (helm#21858)
516c49d 
Signed-off-by: Niels Nuyttens <niels.nuyttens@gmail.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@nielsn @li-adrienloiseau
[stable/mysql] add basic affinity support (helm#12054) (helm#21858)
5a3615f 
Signed-off-by: Niels Nuyttens <niels.nuyttens@gmail.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@nielsn
[stable/mysql] add basic affinity support (helm#12054) (helm#21858)
186d0c1 
Signed-off-by: Niels Nuyttens <niels.nuyttens@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@olemarkus olemarkus Awaiting requested review from olemarkus

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/mysql] add support for affinity
5 participants
@nielsn @k8s-ci-robot @olemarkus @zanhsieh @helm-bot