From 2419a8a1093b633947e68896e814e289247b5ac7 Mon Sep 17 00:00:00 2001 From: Pierluigi Lenoci Date: Tue, 14 Apr 2020 13:49:45 +0200 Subject: [PATCH 1/2] [stable/kube-slack] Added imagePullSecrets option to chart Signed-off-by: Pierluigi Lenoci --- stable/kube-slack/Chart.yaml | 2 +- stable/kube-slack/templates/deployment.yaml | 4 ++++ stable/kube-slack/values.yaml | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/stable/kube-slack/Chart.yaml b/stable/kube-slack/Chart.yaml index 7f4e5c79adf7..a9ffc0fd1697 100644 --- a/stable/kube-slack/Chart.yaml +++ b/stable/kube-slack/Chart.yaml @@ -1,5 +1,5 @@ name: kube-slack -version: 1.3.0 +version: 1.3.1 appVersion: v4.2.0 apiVersion: v1 description: Chart for kube-slack, a monitoring service for Kubernetes diff --git a/stable/kube-slack/templates/deployment.yaml b/stable/kube-slack/templates/deployment.yaml index ac7ef60dbae6..2dfa47976239 100644 --- a/stable/kube-slack/templates/deployment.yaml +++ b/stable/kube-slack/templates/deployment.yaml @@ -41,6 +41,10 @@ spec: - configMapRef: name: {{ template "kube-slack.fullname" . }} resources: + {{- if .Values.imagePullSecrets }} + imagePullSecrets: + - name: {{ .Values.imagePullSecrets | quote }} + {{- end }} {{ toYaml .Values.resources | indent 12 }} {{- if .Values.rbac.create }} serviceAccountName: {{ template "kube-slack.fullname" . }} diff --git a/stable/kube-slack/values.yaml b/stable/kube-slack/values.yaml index 558c5ea29a9e..99b8eb647c4d 100644 --- a/stable/kube-slack/values.yaml +++ b/stable/kube-slack/values.yaml @@ -38,6 +38,7 @@ image: repository: willwill/kube-slack tag: v4.2.0 pullPolicy: IfNotPresent +# imagePullSecrets: "" resources: {} # limits: From 449561a2fb4f27c3d029daec7d4d709d4c170c2d Mon Sep 17 00:00:00 2001 From: Pierluigi Lenoci Date: Tue, 14 Apr 2020 14:55:56 +0200 Subject: [PATCH 2/2] In this way works better Signed-off-by: Pierluigi Lenoci --- stable/kube-slack/templates/deployment.yaml | 4 ++-- stable/kube-slack/values.yaml | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/stable/kube-slack/templates/deployment.yaml b/stable/kube-slack/templates/deployment.yaml index 2dfa47976239..b11993bce9eb 100644 --- a/stable/kube-slack/templates/deployment.yaml +++ b/stable/kube-slack/templates/deployment.yaml @@ -41,9 +41,9 @@ spec: - configMapRef: name: {{ template "kube-slack.fullname" . }} resources: - {{- if .Values.imagePullSecrets }} + {{ if .Values.image.pullSecret }} imagePullSecrets: - - name: {{ .Values.imagePullSecrets | quote }} + - name: {{ .Values.image.pullSecret }} {{- end }} {{ toYaml .Values.resources | indent 12 }} {{- if .Values.rbac.create }} diff --git a/stable/kube-slack/values.yaml b/stable/kube-slack/values.yaml index 99b8eb647c4d..bf7411baae76 100644 --- a/stable/kube-slack/values.yaml +++ b/stable/kube-slack/values.yaml @@ -38,7 +38,8 @@ image: repository: willwill/kube-slack tag: v4.2.0 pullPolicy: IfNotPresent -# imagePullSecrets: "" + # If specified, use these secrets to access the image + # pullSecret: registry-secret resources: {} # limits: