feat: display sys infos #46

hendriknielaender · 2024-02-06T19:30:00Z

Implement enhanced system information retrieval for Linux, macOS, and Windows within platform.zig. This includes accurate fetching of CPU name, core count, and total memory.

Tested on:

MacOS
Linux
Windows

mac is also a Unix ;-)

FObersteiner · 2024-02-12T15:57:46Z

I've modified a few thing on the Linux side of things. Overall, I think this is a cool feature :) I'm not sure if /proc/cpuinfo (meminfo) is available on all Linuxes (there are plenty...) but we can fix that later on I guess, if somebody really needs it.

hendriknielaender · 2024-02-12T16:20:40Z

I've modified a few thing on the Linux side of things. Overall, I think this is a cool feature :) I'm not sure if /proc/cpuinfo (meminfo) is available on all Linuxes (there are plenty...) but we can fix that later on I guess, if somebody really needs it.

Thanks for improving & testing it 👍 Totally agree, if there is a distro where its missing we will fix this in the future.

FObersteiner · 2024-02-14T08:00:14Z

util/os/windows.zig

+}
+
+fn exec(allocator: std.mem.Allocator, args: []const []const u8) ![]const u8 {
+    const stdout = (try std.ChildProcess.exec(.{ .allocator = allocator, .argv = args })).stdout;


This works when compiled in Debug and ReleaseFast mode but causes an "unreachable code" exception in ReleaseSafe. Haven't found out why yet...

Most likely that happens due to a failed assertion or an error that is not properly handled. I don't really know the zig internals for handling this case in ReleaseSafe.

const result = std.ChildProcess.exec(.{ .allocator = allocator, .argv = args }) catch |err| { return err; }; const stdout = result.stdout; ` ``

util/os/windows.zig

util/os/osx.zig

util/os/windows.zig

Bryysen · 2024-02-17T14:41:53Z

Sorry for being late to the party! First of all this a cool feature. I've skimmed through the code but I'll need more time to digest some of it because I'm not too familiar with platform-specific problems like this. I did test it on my Linux machine and it works fine, however when I quickly tested it on my Windows machine I got the compilation errors

Error message

  C:\Users\USERNAME\Desktop\zBench-main>"..\zig-windows-x86_64-0.11.0\zig.exe" build test_examples
  zig test basic Debug native: error: the following command failed with 1 compilation errors:
  C:\Users\USERNAME\Desktop\zig-windows-x86_64-0.11.0\zig.exe test C:\Users\King\Desktop\zBench-main\examples\basic.zig --cache-dir C:\Users\King\Desktop\zBench-main\zig-c
  zig test bubble_sort Debug native: error: the following command failed with 1 compilation errors:
  C:\Users\USERNAME\Desktop\zig-windows-x86_64-0.11.0\zig.exe test C:\Users\King\Desktop\zBench-main\examples\bubble_sort.zig --cache-dir C:\Users\King\Desktop\zBench-main
  zig test sleep Debug native: error: the following command failed with 1 compilation errors:
  C:\Users\USERNAME\Desktop\zig-windows-x86_64-0.11.0\zig.exe test C:\Users\King\Desktop\zBench-main\examples\sleep.zig --cache-dir C:\Users\King\Desktop\zBench-main\zig-c
  Build Summary: 0/7 steps succeeded; 3 failed (disable with --summary none)
  test_examples transitive failure
  +- zig test basic Debug native 1 errors
  +- install basic transitive failure
  |  +- zig test basic Debug native (reused)
  +- zig test bubble_sort Debug native 1 errors
  +- install bubble_sort transitive failure
  |  +- zig test bubble_sort Debug native (reused)
  +- zig test sleep Debug native 1 errors
  +- install sleep transitive failure
     +- zig test sleep Debug native (reused)
  C:\Users\USERNAME\Desktop\zig-windows-x86_64-0.11.0\lib\std\os\windows.zig:1892:28: error: unable to evaluate comptime expression
                  break :blk asm volatile (
                             ^~~
  C:\Users\USERNAME\Desktop\zig-windows-x86_64-0.11.0\lib\std\os\windows.zig:1907:15: note: called from here
      return teb().ProcessEnvironmentBlock;
             ~~~^~                                                                           
  C:\Users\USERNAME\Desktop\zig-windows-x86_64-0.11.0\lib\std\io.zig:36:30: note: called from here
          return os.windows.peb().ProcessParameters.hStdOutput;                                    
                 ~~~~~~~~~~~~~~^~ 
  C:\Users\USERNAME\Desktop\zig-windows-x86_64-0.11.0\lib\std\io.zig:50:34: note: called from here
          .handle = getStdOutHandle(),
                    ~~~~~~~~~~~~~~~^~                                       
  zbench.zig:251:125: note: called from here
      out_stream: std.io.BufferedWriter(1024, @TypeOf(std.io.getStdOut().writer())) = .{ .unbuffered_writer = std.io.getStdOut().writer() },
                                                                                                              ~~~~~~~~~~~~~~~~^~
  C:\Users\USERNAME\Desktop\zig-windows-x86_64-0.11.0\lib\std\os\windows.zig:1892:28: error: unable to evaluate comptime expression
                  break :blk asm volatile (
                             ^~~
  C:\Users\USERNAME\Desktop\zig-windows-x86_64-0.11.0\lib\std\os\windows.zig:1907:15: note: called from here
      return teb().ProcessEnvironmentBlock;
             ~~~^~
  C:\Users\USERNAME\Desktop\zig-windows-x86_64-0.11.0\lib\std\io.zig:36:30: note: called from here
          return os.windows.peb().ProcessParameters.hStdOutput;
                 ~~~~~~~~~~~~~~^~
  C:\Users\USERNAME\Desktop\zig-windows-x86_64-0.11.0\lib\std\io.zig:50:34: note: called from here
          .handle = getStdOutHandle(),
                    ~~~~~~~~~~~~~~~^~
  zbench.zig:251:125: note: called from here
      out_stream: std.io.BufferedWriter(1024, @TypeOf(std.io.getStdOut().writer())) = .{ .unbuffered_writer = std.io.getStdOut().writer() },
                                                                                                              ~~~~~~~~~~~~~~~~^~
  C:\Users\USERNAME\Desktop\zig-windows-x86_64-0.11.0\lib\std\os\windows.zig:1892:28: error: unable to evaluate comptime expression
                  break :blk asm volatile (
                             ^~~
  C:\Users\USERNAME\Desktop\zig-windows-x86_64-0.11.0\lib\std\os\windows.zig:1907:15: note: called from here
      return teb().ProcessEnvironmentBlock;
             ~~~^~
  C:\Users\USERNAME\Desktop\zig-windows-x86_64-0.11.0\lib\std\io.zig:36:30: note: called from here
          return os.windows.peb().ProcessParameters.hStdOutput;
                 ~~~~~~~~~~~~~~^~
  C:\Users\USERNAME\Desktop\zig-windows-x86_64-0.11.0\lib\std\io.zig:50:34: note: called from here
          .handle = getStdOutHandle(),
                    ~~~~~~~~~~~~~~~^~
  zbench.zig:251:125: note: called from here
      out_stream: std.io.BufferedWriter(1024, @TypeOf(std.io.getStdOut().writer())) = .{ .unbuffered_writer = std.io.getStdOut().writer() },

Which point to an error on this line and shouldn't even be related to this PR I'm pretty sure 😅

I'll look into this later when I get some time

FObersteiner · 2024-02-17T14:45:03Z

Which point to an error on this line and shouldn't even be related to this PR I'm pretty sure 😅

I'll look into this later when I get some time

looks like #49 to me - we might move tackling this issue to a bigger overhaul, which you drafted in #39 ?

Bryysen · 2024-02-17T14:50:17Z

Which point to an error on this line and shouldn't even be related to this PR I'm pretty sure 😅
I'll look into this later when I get some time

looks like #49 to me

I've been gone for a while so I haven't been up to date with the latest issues, my bad! Yeah I'll sort this out ASAP (I'm confused how the PR that introduced the change passed the CI though? 🤔)

FObersteiner · 2024-02-17T14:53:42Z

I'm confused how the PR that introduced the change passed the CI though? 🤔

good point; I'm not sure what exactly windows-latest encompasses - I ran this on a "real" Windows 10 (Enterprise) machine and I guess Windows != Windows

edit: it's Windows Server. Historically, those have been quiet different compared to "normal" Windows OS

Bryysen · 2024-02-20T19:02:13Z

Alright #51 should sort the windows issue out, once that gets merged we should be able to test this feature on windows.

FObersteiner · 2024-02-23T06:41:09Z

Alright #51 should sort the windows issue out, once that gets merged we should be able to test this feature on windows.

I think this PR #46 can be merged as well, right?

feat: display sys infos

fd427b9

hendriknielaender added the enhancement New feature or request label Feb 6, 2024

hendriknielaender self-assigned this Feb 6, 2024

hendriknielaender added 3 commits February 6, 2024 20:35

fix: missing os imports

19a21b0

chore: add cpu cores & memory fn

13316aa

chore: improve debug print

3ee6c09

hendriknielaender requested review from Bryysen and FObersteiner February 11, 2024 10:36

hendriknielaender marked this pull request as ready for review February 11, 2024 10:36

FObersteiner added 3 commits February 12, 2024 16:53

use lnx instead of const unix

1f142aa

mac is also a Unix ;-)

fix indentation

ecf7624

revise linux methods

66ee5b9

FObersteiner and others added 3 commits February 12, 2024 17:22

two decimal digits for total mem

e4a0982

typo

fb306a7

minor revisions to platform/windows

64a328c

FObersteiner reviewed Feb 14, 2024

View reviewed changes

FObersteiner and others added 4 commits February 14, 2024 09:55

cleanup linux

6cf599d

cleanup, add bounds checks, fix determination of physical CPU cores

eadcc66

chore: use scoped logger for util/os osx & windows

02ff649

fix: add sufficient length checks

5057e4d

Merge branch 'main' into system-info

7631bf1

hendriknielaender merged commit a211139 into main Feb 23, 2024
5 checks passed

hendriknielaender mentioned this pull request Feb 23, 2024

Enhance Configurability in zbench #40

Closed

hendriknielaender deleted the system-info branch March 19, 2024 11:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: display sys infos #46

feat: display sys infos #46

hendriknielaender commented Feb 6, 2024 •

edited

Loading

FObersteiner commented Feb 12, 2024

hendriknielaender commented Feb 12, 2024

FObersteiner Feb 14, 2024

hendriknielaender Feb 17, 2024

Bryysen commented Feb 17, 2024

FObersteiner commented Feb 17, 2024 •

edited

Loading

Bryysen commented Feb 17, 2024 •

edited

Loading

FObersteiner commented Feb 17, 2024 •

edited

Loading

Bryysen commented Feb 20, 2024

FObersteiner commented Feb 23, 2024 •

edited

Loading

feat: display sys infos #46

feat: display sys infos #46

Conversation

hendriknielaender commented Feb 6, 2024 • edited Loading

FObersteiner commented Feb 12, 2024

hendriknielaender commented Feb 12, 2024

FObersteiner Feb 14, 2024

Choose a reason for hiding this comment

hendriknielaender Feb 17, 2024

Choose a reason for hiding this comment

Bryysen commented Feb 17, 2024

FObersteiner commented Feb 17, 2024 • edited Loading

Bryysen commented Feb 17, 2024 • edited Loading

FObersteiner commented Feb 17, 2024 • edited Loading

Bryysen commented Feb 20, 2024

FObersteiner commented Feb 23, 2024 • edited Loading

hendriknielaender commented Feb 6, 2024 •

edited

Loading

FObersteiner commented Feb 17, 2024 •

edited

Loading

Bryysen commented Feb 17, 2024 •

edited

Loading

FObersteiner commented Feb 17, 2024 •

edited

Loading

FObersteiner commented Feb 23, 2024 •

edited

Loading