Fix percentile calculation, there was an issue with sorting #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bens
force-pushed
the
percentile-fix
branch
2 times, most recently
from
ab69bf3 to
c7c249c
Compare
The last item of the durations array was being left out of the sort, and sometimes I was seeing larger p75 values than p995, which is nonsensical. I've fixed the issue and added some tests and asserts that check for sanity. The average and standard deviation functions looked like they could use some tweaks too.
bens
commented
Mar 12, 2024
bens
commented
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last item of the durations array was being left out of the sort, and sometimes I was seeing larger p75 values than p995, which is nonsensical. I've fixed the issue and added some tests and asserts that check for sanity.
The average and standard deviation functions looked like they could use some tweaks too.