From a73a1ceeca677c4e8c69f8a70bb948e3c833c836 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Kr=C3=B6ning?= Date: Tue, 29 Aug 2023 15:08:04 +0200 Subject: [PATCH 1/2] chore(xtask): remove resolved TODO MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Martin Kröning --- xtask/src/main.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/xtask/src/main.rs b/xtask/src/main.rs index 3f8830f1ad..a8eea92ef9 100644 --- a/xtask/src/main.rs +++ b/xtask/src/main.rs @@ -197,8 +197,6 @@ impl flags::Clippy { fn run(self) -> Result<()> { let sh = sh()?; - // TODO: Enable clippy for aarch64 - // https://github.com/hermitcore/hermit-kernel/issues/381 for target in [Arch::X86_64, Arch::AArch64] { let target_args = target.cargo_args(); cmd!(sh, "cargo clippy {target_args...}").run()?; From b02312c08479e168d7171e3b9e9fac20667dd949 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Kr=C3=B6ning?= Date: Tue, 29 Aug 2023 15:09:12 +0200 Subject: [PATCH 2/2] fix(comments): fix repo links in TODOs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Martin Kröning --- src/arch/aarch64/mm/paging.rs | 2 +- src/macros.rs | 2 +- xtask/src/main.rs | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/arch/aarch64/mm/paging.rs b/src/arch/aarch64/mm/paging.rs index b531949d9c..89402e6907 100644 --- a/src/arch/aarch64/mm/paging.rs +++ b/src/arch/aarch64/mm/paging.rs @@ -510,7 +510,7 @@ where /// Returns the next subtable for the given page in the page table hierarchy. /// /// Must only be called if a page of this size is mapped in a subtable! - // FIXME: https://github.com/hermitcore/hermit-kernel/issues/771 + // FIXME: https://github.com/hermitcore/kernel/issues/771 #[allow(clippy::mut_from_ref)] fn subtable(&self, page: Page) -> &mut PageTable { assert!(L::LEVEL < S::MAP_LEVEL); diff --git a/src/macros.rs b/src/macros.rs index 5d5139bdbc..0601ba4511 100644 --- a/src/macros.rs +++ b/src/macros.rs @@ -104,7 +104,7 @@ macro_rules! kernel_function { } // TODO: Properly switch kernel stack with newlib -// https://github.com/hermitcore/hermit-kernel/issues/471 +// https://github.com/hermitcore/kernel/issues/471 #[cfg(all(target_arch = "x86_64", feature = "newlib"))] macro_rules! kernel_function { ($f:ident($($x:tt)*)) => {{ diff --git a/xtask/src/main.rs b/xtask/src/main.rs index a8eea92ef9..2f9202f090 100644 --- a/xtask/src/main.rs +++ b/xtask/src/main.rs @@ -87,7 +87,7 @@ impl flags::Build { .unwrap_or_default(); // TODO: Re-enable mutable-noalias - // https://github.com/hermitcore/hermit-kernel/issues/200 + // https://github.com/hermitcore/kernel/issues/200 rustflags.push("-Zmutable-noalias=no"); if self.instrument_mcount { @@ -208,7 +208,7 @@ impl flags::Clippy { .arg("--features=acpi,fsgsbase,pci,smp,vga") .run()?; // TODO: Enable clippy for newlib - // https://github.com/hermitcore/hermit-kernel/issues/470 + // https://github.com/hermitcore/kernel/issues/470 // cmd!(sh, "cargo clippy {target_args...}") // .arg("--no-default-features") // .arg("--features=acpi,fsgsbase,newlib,smp,vga")