Fix lint errors with Rust 1.78 beta #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes this lint error I get locally with Rust 1.78 beta: ``` error: lint group `pedantic` has the same priority (0) as a lint --> Cargo.toml:15:1 | 15 | pedantic = "warn" | ^^^^^^^^ ------ has an implicit priority of 0 16 | unwrap_used = "warn" | ----------- has the same priority as this lint | = note: the order of the lints in the table is ignored by Cargo = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority = note: `#[deny(clippy::lint_groups_priority)]` on by default help: to have lints override the group set `pedantic` to a lower priority | 15 | pedantic = { level = "warn", priority = -1 } | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ```
runesoerensen
approved these changes
Mar 21, 2024
edmorley
added a commit
to heroku/buildpacks-deb-packages
that referenced
this pull request
Jul 16, 2024
With newer versions of Rust, Clippy was failing on `main` with: ``` error: lint group `pedantic` has the same priority (0) as a lint --> Cargo.toml:23:1 | 23 | pedantic = "warn" | ^^^^^^^^ ------ has an implicit priority of 0 24 | unwrap_used = "warn" | ----------- has the same priority as this lint | = note: the order of the lints in the table is ignored by Cargo = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority = note: `#[deny(clippy::lint_groups_priority)]` on by default help: to have lints override the group set `pedantic` to a lower priority | 23 | pedantic = { level = "warn", priority = -1 } | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` eg: https://github.com/heroku/buildpacks-apt/actions/runs/9955852891/job/27504486097?pr=32#step:5:188 See also: heroku/buildpacks-python#184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this lint error I get locally with Rust 1.78 beta:
See:
https://rust-lang.github.io/rust-clippy/master/index.html#/lint_groups_priority
rust-lang/rust-clippy#11832
rust-lang/cargo#12918
rust-lang/cargo#13565
GUS-W-15303120.