Use the shared GitHub Actions workflows for buildpack releases #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets up the release automation scripts from [languages-github-actions](https://github.com/heroku/languages-github-actions) for the Python buildpack. Also adds the target Docker repository to `buildpack.toml` to align with the metadata used by other Heroku buildpacks. [W-13658750](https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00001Ul35kYAB/view)
edmorley
reviewed
Jun 29, 2023
|
Thank you for working on this btw! I'll have another review pass once I've had a chance to test some more, and once we've triaged some more of https://github.com/heroku/languages-github-actions/issues :-) |
edmorley
requested changes
Jul 11, 2023
There was a problem hiding this comment.
Marking changes requested to make the current state clearer.
This is blocked on:
- the review comments on the PR
- having a few more of the issues reported at https://github.com/heroku/languages-github-actions/issues fixed first
...but I'm very much looking forward to this landing! :-)
edmorley
changed the title
colincasey
added a commit
to heroku/languages-github-actions
that referenced
this pull request
Aug 3, 2023
We can remove these separated workflows now that the following PRs have been merged: - heroku/buildpacks-jvm#554 - heroku/buildpacks-php#14 - heroku/buildpacks-go#123 - heroku/buildpacks-ruby#183 - heroku/buildpacks-nodejs#609 - heroku/buildpacks-python#58 - heroku/buildpacks-procfile#156
colincasey
added a commit
to heroku/languages-github-actions
that referenced
this pull request
Aug 3, 2023
We can remove this fallback key for reading the repository to publish to now that the following PRs have been merged: - heroku/buildpacks-go#124 - heroku/buildpacks-php#15 - heroku/buildpacks-ruby#184 - heroku/buildpacks-jvm#555 - heroku/buildpacks-nodejs#610 - heroku/buildpacks-python#58 - heroku/buildpacks-procfile#156
colincasey
added a commit
to heroku/languages-github-actions
that referenced
this pull request
Aug 3, 2023
We can remove this fallback key for reading the repository to publish to now that the following PRs have been merged: - heroku/buildpacks-go#124 - heroku/buildpacks-php#15 - heroku/buildpacks-ruby#184 - heroku/buildpacks-jvm#555 - heroku/buildpacks-nodejs#610 - heroku/buildpacks-python#58 - heroku/buildpacks-procfile#156
colincasey
added a commit
to heroku/languages-github-actions
that referenced
this pull request
Aug 4, 2023
* Post PR #91 Cleanup We can remove these separated workflows now that the following PRs have been merged: - heroku/buildpacks-jvm#554 - heroku/buildpacks-php#14 - heroku/buildpacks-go#123 - heroku/buildpacks-ruby#183 - heroku/buildpacks-nodejs#609 - heroku/buildpacks-python#58 - heroku/buildpacks-procfile#156 * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up the release automation scripts from languages-github-actions for the Python buildpack.
Also adds the target Docker repository to
buildpack.tomlto align with the metadata used by other Heroku buildpacks.GUS-W-13658750.