Add target triple to buildpack output path #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malax
added
enhancement
Malax
force-pushed
the
malax/add-target-triple-to-bp-target-dir
branch
2 times, most recently
from
7151a23
to
0769f87
Compare
Malax
force-pushed
the
malax/add-target-triple-to-bp-target-dir
branch
from
5297a16
to
1025f4d
Compare
edmorley
reviewed
Jun 22, 2023
edmorley
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a buildpack for multiple target triples, the same output directory is currently used by
libcnb-cargo, clobbering earlier builds for other target triples. This PR changes the output directory to include the target triple, just as cargo itself does.Fixes #579