Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent error enum style #631

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Consistent error enum style #631

merged 1 commit into from
Aug 22, 2023

Conversation

colincasey
Copy link
Contributor

This is a general cleanup PR to make the error enums in libcnb-package and libcnb-cargo consistent with the tuple-style used elsewhere in the codebase.

@colincasey colincasey self-assigned this Aug 11, 2023
@colincasey colincasey requested a review from a team as a code owner August 11, 2023 18:01
@colincasey colincasey mentioned this pull request Aug 17, 2023
Merged
Malax
Malax reviewed Aug 18, 2023
View reviewed changes
Copy link
Member

@Malax Malax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through this one, nothing controversial in here - should be good to merge after the merge conflicts are out of the way. Approval follows then.

@colincasey colincasey requested a review from Malax August 18, 2023 18:03
@colincasey @Malax
Consistent error enum style
cf240c4 
This is a general cleanup PR to make the error enums in `libcnb-package` and `libcnb-cargo` consistent with the tuple-style used elsewhere in the codebase.
@Malax Malax force-pushed the libcnb-package/consistent_enums branch from 2a74935 to cf240c4 Compare August 22, 2023 09:27
@Malax Malax merged commit 1b030a1 into main Aug 22, 2023
@Malax Malax deleted the libcnb-package/consistent_enums branch August 22, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Malax Malax Malax approved these changes

Assignees

@colincasey colincasey

Labels
breaking change libcnb-cargo libcnb-package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colincasey @Malax @edmorley