From b1da8f127b2f3395d5f105e10eb96f762709ca4f Mon Sep 17 00:00:00 2001 From: camcam <67684008+camcam2605@users.noreply.github.com> Date: Fri, 21 Jul 2023 00:17:46 +0700 Subject: [PATCH 1/2] Update chip.ts fix(Chip): fixed chip style issue one char with close button --- packages/core/theme/src/components/chip.ts | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/packages/core/theme/src/components/chip.ts b/packages/core/theme/src/components/chip.ts index d7b1bbc8d6..fc1590657a 100644 --- a/packages/core/theme/src/components/chip.ts +++ b/packages/core/theme/src/components/chip.ts @@ -120,12 +120,6 @@ const chip = tv({ hasEndContent: { true: {}, }, - isOneChar: { - true: { - base: "px-0 justify-center", - content: "px-0 flex-none", - }, - }, isDisabled: { true: {base: "opacity-disabled pointer-events-none"}, }, @@ -423,6 +417,22 @@ const chip = tv({ base: "w-7 h-7 min-w-unit-7 min-h-7", }, }, + // isOneChar / isCloseable + { + isOneChar: true, + isCloseable: false, + class: { + base: "px-0 justify-center", + content: "px-0 flex-none", + } + }, + { + isOneChar: true, + isCloseable: true, + class: { + base: "w-auto", + } + }, // hasStartContent / size { hasStartContent: true, From 9ade2a657931fd3b2d5bb375ed38be0f9c6d08c8 Mon Sep 17 00:00:00 2001 From: camcam <67684008+camcam2605@users.noreply.github.com> Date: Fri, 21 Jul 2023 00:19:28 +0700 Subject: [PATCH 2/2] Update use-chip.ts fix(Chip): added isCloseable variant --- packages/components/chip/src/use-chip.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/components/chip/src/use-chip.ts b/packages/components/chip/src/use-chip.ts index 65c6db0872..376f631c8e 100644 --- a/packages/components/chip/src/use-chip.ts +++ b/packages/components/chip/src/use-chip.ts @@ -99,6 +99,7 @@ export function useChip(originalProps: UseChipProps) { hasStartContent, hasEndContent, isOneChar, + isCloseable, isCloseButtonFocusVisible, }), [ @@ -107,6 +108,7 @@ export function useChip(originalProps: UseChipProps) { hasStartContent, hasEndContent, isOneChar, + isCloseable, ], );