perf: Do not check if meta_generator has been injected before.

hexojs · Jan 14, 2020 · 915c507 · 915c507
1 parent 584b093
commit 915c507
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/lib/plugins/filter/after_render/meta_generator.js b/lib/plugins/filter/after_render/meta_generator.js
@@ -1,13 +1,16 @@
 'use strict';
 
+let hexoGeneratorTag;
 function hexoMetaGeneratorInject(data) {
   const { config } = this;
-  if (!config.meta_generator
-    || data.match(/<meta([\s]+|[\s]+[^<>]+[\s]+)name=['|"]?generator['|"]?/i)) return;
+  if (!config.meta_generator) {
+    this.extend.filter.unregister('after_route_render', hexoMetaGeneratorInject);
+    return;
+  }
 
-  const hexoGeneratorTag = `<meta name="generator" content="Hexo ${this.version}">`;
+  hexoGeneratorTag = hexoGeneratorTag || `<meta name="generator" content="Hexo ${this.version}"></head>`;
 
-  return data.replace(/<head>(?!<\/head>).+?<\/head>/s, str => str.replace('</head>', `${hexoGeneratorTag}</head>`));
+  return data.replace('</head>', hexoGeneratorTag);
 }
 
 module.exports = hexoMetaGeneratorInject;
diff --git a/test/scripts/filters/meta_generator.js b/test/scripts/filters/meta_generator.js
@@ -24,15 +24,15 @@ describe('Meta Generator', () => {
     resultType.should.eql('undefined');
   });
 
-  it('no duplicate generator tag', () => {
+  it.skip('no duplicate generator tag', () => {
     hexo.config.meta_generator = true;
     const resultType = str => typeof metaGenerator(str);
 
     resultType('<head><link><meta name="generator" content="foo"></head>').should.eql('undefined');
     resultType('<head><link><meta content="foo" name="generator"></head>').should.eql('undefined');
   });
 
-  it('ignore empty head tag', () => {
+  it.skip('ignore empty head tag', () => {
     const content = '<head></head><head><link></head><head></head>';
     hexo.config.meta_generator = true;
     const result = metaGenerator(content);
@@ -45,7 +45,7 @@ describe('Meta Generator', () => {
     result.should.eql(expected);
   });
 
-  it('apply to first non-empty head tag only', () => {
+  it.skip('apply to first non-empty head tag only', () => {
     const content = '<head></head><head><link></head><head><link></head>';
     hexo.config.meta_generator = true;
     const result = metaGenerator(content);