Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_config.yml does not overwrite themes _config.yml #2253

Closed
guileen opened this issue Nov 10, 2016 · 4 comments
Closed

_config.yml does not overwrite themes _config.yml #2253

guileen opened this issue Nov 10, 2016 · 4 comments

Comments

@guileen
Copy link

guileen commented Nov 10, 2016

I use submodule to add theme, and I need to change the theme configuration. I overwrite it at root _config.yml, but it does not works, then I modify at themes _config.yml, it works.

hexo: 3.2.2
hexo-cli: 1.0.2
os: Darwin 15.6.0 darwin x64
http_parser: 2.7.0
node: 6.3.0
v8: 5.0.71.52
uv: 1.9.1
zlib: 1.2.8
ares: 1.10.1-DEV
icu: 57.1
modules: 48
openssl: 1.0.2h

@guileen
Copy link
Author

guileen commented Nov 10, 2016

I found #757 has make this feature. But there is no document for it.

@guileen guileen closed this as completed Nov 10, 2016
@NoahDragon
Copy link
Member

It is reverse way, theme config overwrite root config.

@mnghsn
Copy link

mnghsn commented Nov 12, 2016

I think that root config should overwrite theme config. So we can define the theme in root config without modifying the theme. It will be useful if you install the theme as a Git submodule.

@NoahDragon
Copy link
Member

@jmlntw True, I encountered the same issue. What my solution is:

  1. remove submodule,
  2. fork the theme on my own repo.

Using theme config to overwrite the root config is more logic (specific cases suppress generic cases), and also reduces the complexity when debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants