From 4b6177e3e3d297ae0ccdd22860cd487aa744971f Mon Sep 17 00:00:00 2001 From: curbengh <43627182+curbengh@users.noreply.github.com> Date: Tue, 10 Dec 2019 12:49:24 +0000 Subject: [PATCH 1/2] fix(meta_generator): parse correct version --- lib/plugins/helper/meta_generator.js | 2 +- test/scripts/helpers/meta_generator.js | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/plugins/helper/meta_generator.js b/lib/plugins/helper/meta_generator.js index 590d6c8d95..20b7613939 100755 --- a/lib/plugins/helper/meta_generator.js +++ b/lib/plugins/helper/meta_generator.js @@ -1,7 +1,7 @@ 'use strict'; function metaGeneratorHelper() { - return ``; + return ``; } module.exports = metaGeneratorHelper; diff --git a/test/scripts/helpers/meta_generator.js b/test/scripts/helpers/meta_generator.js index b08cc94f11..c6c75b5ed5 100755 --- a/test/scripts/helpers/meta_generator.js +++ b/test/scripts/helpers/meta_generator.js @@ -7,6 +7,10 @@ describe('meta_generator', () => { const metaGeneratorHelper = require('../../../lib/plugins/helper/meta_generator').bind(hexo); it('default', () => { - metaGeneratorHelper().should.eql(``); + const version = hexo.env.version; + const versionType = typeof version; + + versionType.should.not.eql('undefined'); + metaGeneratorHelper().should.eql(``); }); }); From bb430d235c9f37e47608beed4ddca40fa7f5d2bc Mon Sep 17 00:00:00 2001 From: curbengh <43627182+curbengh@users.noreply.github.com> Date: Wed, 11 Dec 2019 01:10:07 +0000 Subject: [PATCH 2/2] refactor(meta_generator_helper): destructure --- test/scripts/helpers/meta_generator.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/scripts/helpers/meta_generator.js b/test/scripts/helpers/meta_generator.js index c6c75b5ed5..98d7b75175 100755 --- a/test/scripts/helpers/meta_generator.js +++ b/test/scripts/helpers/meta_generator.js @@ -7,7 +7,7 @@ describe('meta_generator', () => { const metaGeneratorHelper = require('../../../lib/plugins/helper/meta_generator').bind(hexo); it('default', () => { - const version = hexo.env.version; + const { version } = hexo; const versionType = typeof version; versionType.should.not.eql('undefined');