Skip to content

[3.2] MariaDB, mutation delete query does not delete an entity with joined inheritance #2752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
Merged

[3.2] MariaDB, mutation delete query does not delete an entity with joined inheritance #2752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94823e5
[#2737] MariaDB, mutation delete query does not delete an entity with…
dreab8 Nov 6, 2025
135e625
[#2737] Add test for MariaDB, mutation delete query does not delete a…
dreab8 Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...rnate/reactive/query/sqm/mutation/internal/temptable/ReactiveTableBasedDeleteHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,12 @@ public CompletionStage<Integer> reactiveExecute(JdbcParameterBindings jdbcParame

private CompletionStage<Void> deleteRows(JdbcParameterBindings jdbcParameterBindings, StandardReactiveJdbcMutationExecutor jdbcMutationExecutor, SqmJdbcExecutionContextAdapter executionContext, int[] rows) {
if ( getEntityDescriptor() instanceof UnionSubclassEntityPersister ) {
return CompletionStages
.loop( getDeletes(), delete -> reactiveExecute( jdbcParameterBindings, delete, jdbcMutationExecutor, executionContext )
return loop( getDeletes(), delete -> reactiveExecute( jdbcParameterBindings, delete, jdbcMutationExecutor, executionContext )
.thenApply( tot -> rows[0] += tot )
);
}
else {
return CompletionStages
.loop( getDeletes(), delete -> reactiveExecute( jdbcParameterBindings, delete, jdbcMutationExecutor, executionContext )
return loop( getDeletes(), delete -> reactiveExecute( jdbcParameterBindings, delete, jdbcMutationExecutor, executionContext )
.thenApply( tot -> rows[0] = tot )
);
}
Expand All @@ -128,8 +126,10 @@ private CompletionStage<Integer> executeDelete(
);
}
return loop( getCollectionTableDeletes(), delete ->
reactiveExecute( jdbcParameterBindings, delete, jdbcMutationExecutor, executionContext )
).thenApply( v -> rows );
reactiveExecute( jdbcParameterBindings, delete, jdbcMutationExecutor, executionContext )
).thenCompose( v -> loop( getDeletes(), delete ->
reactiveExecute( jdbcParameterBindings, delete, jdbcMutationExecutor, executionContext )
) ).thenApply( v -> rows );
}

private static CompletionStage<Integer> reactiveExecute(
Expand Down
23 changes: 23 additions & 0 deletions ...ate-reactive-core/src/test/java/org/hibernate/reactive/JoinedSubclassInheritanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,29 @@ public void testHqlInsertWithTransaction(VertxTestContext context) {
);
}

@Test
public void testHqlDelete(VertxTestContext context) {
final Integer id = 1;
final String title = "Spell Book: A Comprehensive Guide to Magic Spells and Incantations";
SpellBook spellBook = new SpellBook( id, title, true, new Date() );
test( context, getMutinySessionFactory().withTransaction( session -> session.persist( spellBook ) )
.call( () -> getMutinySessionFactory().withTransaction( session -> session
.createMutationQuery(
"delete from SpellBook where id = :id and forbidden = :forbidden and title = :title" )
.setParameter( "id", id )
.setParameter( "title", title )
.setParameter( "forbidden", true )
.executeUpdate() )
)
.call( () -> getMutinySessionFactory().withTransaction( session -> session
.createSelectionQuery( "from SpellBook g where g.id = :id ", SpellBook.class )
.setParameter( "id", id )
.getSingleResultOrNull()
.invoke( Assertions::assertNull ) )
)
);
}

@Entity(name="SpellBook")
@Table(name = "SpellBookJS")
@DiscriminatorValue("S")
Expand Down
Loading