Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel Id larger than Integer.MAX_VALUE not supported #690

Closed
matenhagen opened this issue May 21, 2021 · 0 comments · Fixed by #691
Closed

Channel Id larger than Integer.MAX_VALUE not supported #690

matenhagen opened this issue May 21, 2021 · 0 comments · Fixed by #691

Comments

@matenhagen
Copy link
Contributor

Exception in thread "main" java.lang.IllegalArgumentException: Invalid value: -1485377672
at net.schmizz.sshj.common.Buffer.putUInt32(Buffer.java:320)
at net.schmizz.sshj.connection.channel.AbstractChannel.newBuffer(AbstractChannel.java:355)
at net.schmizz.sshj.connection.channel.AbstractChannel.sendChannelRequest(AbstractChannel.java:381)
at net.schmizz.sshj.connection.channel.direct.SessionChannel.startSubsystem(SessionChannel.java:188)
at net.schmizz.sshj.sftp.SFTPEngine.(SFTPEngine.java:68)
at net.schmizz.sshj.sftp.SFTPEngine.(SFTPEngine.java:60)
at net.schmizz.sshj.SSHClient.newSFTPClient(SSHClient.java:722)
matenhagen added a commit to matenhagen/sshj that referenced this issue May 21, 2021
@matenhagen
Support writing unsigned integers to buffer, this is required to supp…
ac6d5cc 
…ort channel ids greater than Integer.MAX_VALUE

fixes hierynomus#690
@matenhagen matenhagen mentioned this issue May 21, 2021
Merged
@matenhagen matenhagen changed the title Channel Id larger then Integer.MAX_VALUE not supported Channel Id larger than Integer.MAX_VALUE not supported May 21, 2021
hierynomus added a commit that referenced this issue May 26, 2021
@matenhagen @hierynomus
Support writing unsigned integers to buffer (#691)
0882efb 
* Support writing unsigned integers to buffer, this is required to support channel ids greater than Integer.MAX_VALUE
fixes #690

* Fix incorrect test

* Fix indentation to make codacy happy

Co-authored-by: Jeroen van Erp <jeroen@hierynomus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support writing unsigned integers to buffer matenhagen/sshj
1 participant
@matenhagen