Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New language for PostgreSQL SQL dialect and PL/pgSQL #1804

Merged
merged 12 commits into from
Aug 31, 2018

Conversation

egor-rogov
Copy link
Collaborator

This language incorporates both PostgreSQL SQL dialect and PL/pgSQL language. It is based on upcoming version 11 of PostgreSQL.

Due to uncommon PostgreSQL syntax for string constants (so called "dollar-quoting"), I had to invent a new mode attribute (which I called "endSameAsBegin"). It is documented in docs/reference.rst.

@egor-rogov
Copy link
Collaborator Author

Hi maintainers of the project,
is there anything I can do to speed up review of this PR?
@marcoscaceres

Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@marcoscaceres marcoscaceres merged commit 3fd5bd8 into highlightjs:master Aug 31, 2018
@egor-rogov
Copy link
Collaborator Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants