Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests) auto-generated markup tests for all languages #2862

Merged
merged 2 commits into from
Nov 17, 2020
Merged

chore(tests) auto-generated markup tests for all languages #2862

merged 2 commits into from
Nov 17, 2020

Conversation

joshgoebel
Copy link
Member

This is to help with regression testing in the future as markup tests
serve as a quick and easy anti-regression measure.

Changes

  • Added markup test for EVERY language
  • Copied over the detection default cases test/lang/detect.txt, etc
  • Auto-generated the missing markup tests with current rendered output

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md
  • Added myself to AUTHORS.txt, under Contributors

@joshgoebel joshgoebel mentioned this pull request Nov 13, 2020
Merged
4 tasks
egor-rogov
egor-rogov approved these changes Nov 16, 2020
View reviewed changes
Copy link
Collaborator

@egor-rogov egor-rogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better than nothing I guess.

@joshgoebel
Copy link
Member Author

Well I can be improved over time. It’s just a start.

@joshgoebel joshgoebel merged commit 6698b8a into highlightjs:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egor-rogov egor-rogov egor-rogov approved these changes

@allejo allejo Awaiting requested review from allejo

Assignees
No one assigned
Labels
parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshgoebel @egor-rogov