Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Cybertopia themes #4124

Merged
merged 7 commits into from
Oct 31, 2024
Merged

add Cybertopia themes #4124

merged 7 commits into from
Oct 31, 2024

Conversation

noraj
Copy link
Contributor

@noraj noraj commented Sep 30, 2024

New theme with 4 variants, source here (with screenshots): https://github.com/noraj/cybertopia-highlightjs

@noraj noraj changed the title Cybertopia add Cybertopia themes Sep 30, 2024
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

4 Added Files

View Changes
file size
styles/cybertopia-cherry.min.css +505 B
styles/cybertopia-dimmer.min.css +522 B
styles/cybertopia-icecap.min.css +510 B
styles/cybertopia-saturated.min.css +524 B

3 files changed

Total change -3 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB -1 B
es/highlight.min.js 8.18 KB 8.18 KB -1 B
highlight.min.js 8.22 KB 8.22 KB -1 B

Copy link
Member

@joshgoebel joshgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@noraj noraj requested a review from joshgoebel October 1, 2024 19:14
Copy link

github-actions bot commented Oct 1, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

4 Added Files

View Changes
file size
styles/cybertopia-cherry.min.css +506 B
styles/cybertopia-dimmer.min.css +522 B
styles/cybertopia-icecap.min.css +510 B
styles/cybertopia-saturated.min.css +524 B

3 files changed

Total change -3 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB -1 B
es/highlight.min.js 8.18 KB 8.18 KB -1 B
highlight.min.js 8.22 KB 8.22 KB -1 B

@noraj noraj mentioned this pull request Oct 1, 2024
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

4 Added Files

View Changes
file size
styles/cybertopia-cherry.min.css +506 B
styles/cybertopia-dimmer.min.css +522 B
styles/cybertopia-icecap.min.css +510 B
styles/cybertopia-saturated.min.css +524 B

3 files changed

Total change +4 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB +1 B
es/highlight.min.js 8.18 KB 8.18 KB +1 B
highlight.min.js 8.22 KB 8.22 KB +2 B

@joshgoebel
Copy link
Member

I almost forgot about checkTheme.js... please run it and add the few missing styles to your theme. You can ignore the optional ones if you really want, but we'd like to see all the non-optional ones to include new themes here.

I'll also try to find the time to fix the accessibiltiy checks to work with variables - since we also care about the accessibility of our themes out of the box.

@noraj
Copy link
Contributor Author

noraj commented Oct 29, 2024

Great suggestion, I'll run checkTheme.js as asked in theme-guide and add the missing styles.

For accessibility, I checked the contrast against WCAG at https://webaim.org/resources/contrastchecker/.

Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

4 Added Files

View Changes
file size
styles/cybertopia-cherry.min.css +506 B
styles/cybertopia-dimmer.min.css +522 B
styles/cybertopia-icecap.min.css +510 B
styles/cybertopia-saturated.min.css +524 B

2 files changed

Total change +2 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB +1 B
es/highlight.min.js 8.18 KB 8.18 KB +1 B

Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

4 Added Files

View Changes
file size
styles/cybertopia-cherry.min.css +548 B
styles/cybertopia-dimmer.min.css +565 B
styles/cybertopia-icecap.min.css +551 B
styles/cybertopia-saturated.min.css +567 B

3 files changed

Total change +3 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB +1 B
es/highlight.min.js 8.18 KB 8.18 KB +1 B
highlight.min.js 8.22 KB 8.22 KB +1 B

@joshgoebel
Copy link
Member

Could you please rebase to resolve conflicts?

Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

4 Added Files

View Changes
file size
styles/cybertopia-cherry.min.css +548 B
styles/cybertopia-dimmer.min.css +565 B
styles/cybertopia-icecap.min.css +551 B
styles/cybertopia-saturated.min.css +567 B

3 files changed

Total change -8 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB -3 B
es/highlight.min.js 8.18 KB 8.18 KB -3 B
highlight.min.js 8.22 KB 8.22 KB -2 B

@joshgoebel joshgoebel merged commit a7685d2 into highlightjs:main Oct 31, 2024
19 checks passed
@joshgoebel
Copy link
Member

Boom. Merged! Thanks so much.

@noraj noraj deleted the cybertopia branch October 31, 2024 22:00
@noraj
Copy link
Contributor Author

noraj commented Oct 31, 2024

Thank you for the guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants