Update GitHub workflow actions #94
Conversation
|
@Marcono1234 - thanks for the PR!
Certainly, feel free to do it on this PR or a follow-on, up to you 🙂
Thank you for mentioning that. Would you be willing to open a PR to add the |
| @@ -94,8 +88,6 @@ ignore = [ | |||
| # More documentation for the licenses section can be found here: | |||
| # https://embarkstudios.github.io/cargo-deny/checks/licenses/cfg.html | |||
| [licenses] | |||
| # The lint level for crates which do not have a detectable license | |||
| unlicensed = "deny" | |||
| # List of explicitly allowed licenses | |||
| # See https://spdx.org/licenses/ for list of possible licenses | |||
| # [possible values: any SPDX 3.11 short identifier (+ optional exception)]. | |||
There was a problem hiding this comment.
If I see it correctly, the licenses.allow here was the only thing you manually changed from https://github.com/EmbarkStudios/cargo-deny/blob/0.14.4/deny.template.toml#L102-L106 (?). So I kept those manual changes.
There was a problem hiding this comment.
Yes, that's correct. I wanted to keep the allow list explicit so it can be expanded as needed.
| github = [""] | ||
| github = [] | ||
| # 1 or more gitlab.com organizations to allow git sources for | ||
| gitlab = [""] | ||
| gitlab = [] | ||
| # 1 or more bitbucket.org organizations to allow git sources for | ||
| bitbucket = [""] | ||
| bitbucket = [] |
There was a problem hiding this comment.
| # Based on https://github.com/EmbarkStudios/cargo-deny/blob/0.16.0/deny.template.toml | ||
| # (diff with that version to see what has been manually changed here) |
There was a problem hiding this comment.
I took everything from that template, except for the manual changes mentioned by my other GitHub comments.
| @@ -94,8 +88,6 @@ ignore = [ | |||
| # More documentation for the licenses section can be found here: | |||
| # https://embarkstudios.github.io/cargo-deny/checks/licenses/cfg.html | |||
| [licenses] | |||
| # The lint level for crates which do not have a detectable license | |||
| unlicensed = "deny" | |||
| # List of explicitly allowed licenses | |||
| # See https://spdx.org/licenses/ for list of possible licenses | |||
| # [possible values: any SPDX 3.11 short identifier (+ optional exception)]. | |||
There was a problem hiding this comment.
Yes, that's correct. I wanted to keep the allow list explicit so it can be expanded as needed.
checkout@v3is outdated and currently shows the following warning for your workflow runs:There is also a new version for cargo-deny-action: v2.0.0
Should I update that as well? And update
deny.tomlto match the current template?As side note: You can configure Dependabot to automatically create PRs for updating the used actions.