-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle of enhancements and fixes #18
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(improve network traffic DM for Fortinet and Netscaler) app may contain / and space new regex for *_interface, rule and session_id
- Adds output to show the base search (constraints) of the data model objects to help users know what base tags and filters are in place. - Includes a table level or event output for the sample events collected. These can be displayed in either normal mode (all results) or in cluster mode (collapse grouping of similar events into a single sample event.) - Adds a "Breakdown by eventtype" panels shows related eventtype, their base search, and tags. (Helpful when trying to determine how/why certain events match the sample data.) - Adds a "Breakdown by sourcetype and index" panel showing how the events are distributed across these two common fields.
… into lowell-feature
Fix Visualization drop-down default value (which kept the search results from showing up)
- Fixed issue where the "datamodel" dropdown option was not selectable. (Not sure this ever worked correctly, but it seems to now.) This hides the eventtype breakdown (since eventtype is not included in the CIM models.) - Show the datamodel label instead of the internal name in the drop-down. This allows things like the phrase "(Deprecated)" to be visible to the user.
Found this laying on my hard drive from Dec 2017. Let's let others test it out.
- Fixed up titles for the event viewer - Add some descriptive text to the bottom two breakdown tables.
- CIM Validator now honors the "Show only recommended" input selection. - Limit the number of values for the 'app' field in the "Breakdown by sourcetype and index" panel
- Ran 'ksconf xml-format' on all dashboards (normalize XML) - Hand formatted the most massive searches for readability
lowell80
force-pushed
the
feat-lowell-sync-upstream
branch
from
October 8, 2020 21:46
9b0e1b5
to
5a43bc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vladimir,
I'm finally getting around to a PR! Here's a collection of enhancements that I've been working with locally that would be nice to see in the upstream version, if you like them. I just pulled in your most recent enhancements into my forked version and would rather share this out then have to merge again. :-)
Changes:
Other minor changes:
Okay, last note! I also ran a code formatter which makes bloats the diff a bit. It's all in one commit (5a43bc5) so it can easily be reversed if you'd rather not, or want to see a smaller diff.