Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle of enhancements and fixes #18

Closed

Conversation

lowell80
Copy link
Contributor

@lowell80 lowell80 commented Apr 8, 2020

Vladimir,

I'm finally getting around to a PR! Here's a collection of enhancements that I've been working with locally that would be nice to see in the upstream version, if you like them. I just pulled in your most recent enhancements into my forked version and would rather share this out then have to merge again. :-)

Changes:

Other minor changes:

  • Shows the user the base-search selection (because if you're like me, I sometimes forget which tags go with which datamodel.)
  • I started on a tstats-based data validation model (in a separate view). This isn't complete, but may be good enough to inspire some additional work. I didn't add it to the nav as it wasn't fully cooked.
  • Expanded the "Events" panel to allow either table or event mode. You can get either all the results, or a representational sample (uses the "cluster" command). And the fields shown in the table can be limited to just the "recommended" ones, based on your new lookup.

Okay, last note! I also ran a code formatter which makes bloats the diff a bit. It's all in one commit (5a43bc5) so it can easily be reversed if you'd rather not, or want to see a smaller diff.

araman-m and others added 16 commits June 16, 2016 14:20
(improve network traffic DM for Fortinet and Netscaler)
app may contain / and space
new regex for *_interface, rule and session_id
- Adds output to show the base search (constraints) of the data model objects to help users know what base tags and filters are in place.
- Includes a table level or event output for the sample events collected.  These can be displayed in either normal mode (all results) or in cluster mode (collapse grouping of similar events into a single sample event.)
- Adds a "Breakdown by eventtype" panels shows related eventtype, their base search, and tags.  (Helpful when trying to determine how/why certain events match the sample data.)
- Adds a "Breakdown by sourcetype and index" panel showing how the events are distributed across these two common fields.
Fix Visualization drop-down default value (which kept the search results from showing up)
- Fixed issue where the "datamodel" dropdown option was not selectable.  (Not sure this ever worked correctly, but it seems to now.)  This hides the eventtype breakdown (since eventtype is not included in the CIM models.)
- Show the datamodel label instead of the internal name in the drop-down.  This allows things like the phrase "(Deprecated)" to be visible to the user.
Found this laying on my hard drive from Dec 2017.   Let's let others test it out.
- Fixed up titles for the event viewer
- Add some descriptive text to the bottom two breakdown tables.
- CIM Validator now honors the "Show only recommended" input selection.
- Limit the number of values for the 'app' field in the "Breakdown by
  sourcetype and index" panel
- Ran 'ksconf xml-format' on all dashboards (normalize XML)
- Hand formatted the most massive searches for readability
@lowell80 lowell80 force-pushed the feat-lowell-sync-upstream branch from 9b0e1b5 to 5a43bc5 Compare October 8, 2020 21:46
@lowell80 lowell80 closed this Mar 21, 2023
@lowell80 lowell80 deleted the feat-lowell-sync-upstream branch March 21, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants