Skip to content

fix: set empty ETags for cache-controller db errors #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rafaelcr merged 1 commit into from
Oct 20, 2022
Merged

fix: set empty ETags for cache-controller db errors #1368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 44 additions & 27 deletions src/api/controllers/cache-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,41 +249,58 @@ async function calculateETag(
): Promise<ETag | undefined> {
switch (etagType) {
case ETagType.chainTip:
const chainTip = await db.getUnanchoredChainTip();
if (!chainTip.found) {
// This should never happen unless the API is serving requests before it has synced any blocks.
try {
const chainTip = await db.getUnanchoredChainTip();
if (!chainTip.found) {
// This should never happen unless the API is serving requests before it has synced any
// blocks.
return;
}
return chainTip.result.microblockHash ?? chainTip.result.indexBlockHash;
} catch (error) {
logger.error(`Unable to calculate chain_tip ETag: ${error}`);
return;
}
return chainTip.result.microblockHash ?? chainTip.result.indexBlockHash;

case ETagType.mempool:
const digest = await db.getMempoolTxDigest();
if (!digest.found) {
// This should never happen unless the API is serving requests before it has synced any blocks.
try {
const digest = await db.getMempoolTxDigest();
if (!digest.found) {
// This should never happen unless the API is serving requests before it has synced any
// blocks.
return;
}
if (digest.result.digest === null) {
// A `null` mempool digest means the `bit_xor` postgres function is unavailable.
return ETAG_EMPTY;
}
return digest.result.digest;
} catch (error) {
logger.error(`Unable to calculate mempool ETag: ${error}`);
return;
}
if (digest.result.digest === null) {
// A `null` mempool digest means the `bit_xor` postgres function is unavailable.
return ETAG_EMPTY;
}
return digest.result.digest;

case ETagType.transaction:
const { tx_id } = req.params;
const normalizedTxId = normalizeHashString(tx_id);
if (normalizedTxId === false) {
return ETAG_EMPTY;
}
const status = await db.getTxStatus(normalizedTxId);
if (!status.found) {
return ETAG_EMPTY;
try {
const { tx_id } = req.params;
const normalizedTxId = normalizeHashString(tx_id);
if (normalizedTxId === false) {
return ETAG_EMPTY;
}
const status = await db.getTxStatus(normalizedTxId);
if (!status.found) {
return ETAG_EMPTY;
}
const elements: string[] = [
normalizedTxId,
status.result.index_block_hash ?? '',
status.result.microblock_hash ?? '',
status.result.status.toString(),
];
return elements.join(':');
} catch (error) {
logger.error(`Unable to calculate transaction ETag: ${error}`);
return;
}
const elements: string[] = [
normalizedTxId,
status.result.index_block_hash ?? '',
status.result.microblock_hash ?? '',
status.result.status.toString(),
];
return elements.join(':');
}
}