[Stacks 2.1] fix: synthetic tx parsing for pox2 bitcoin-ops #1505

zone117x · 2023-01-05T16:58:25Z

Fix parsing "Bitcoin-op" Stack-stx txs for pox-2 described at stacks-network/stacks-core#3465

github-actions · 2023-01-05T17:02:12Z

🚀 Deployed on https://deploy-preview-1505--stacks-blockchain-api.netlify.app

codecov-commenter · 2023-01-05T17:03:31Z

Codecov Report

Merging #1505 (c024e5c) into develop (ebd8fff) will increase coverage by 1.54%.
The diff coverage is 78.53%.

@@             Coverage Diff             @@
##           develop    #1505      +/-   ##
===========================================
+ Coverage    77.23%   78.78%   +1.54%     
===========================================
  Files          107       77      -30     
  Lines        10124    10835     +711     
  Branches      2177     2397     +220     
===========================================
+ Hits          7819     8536     +717     
- Misses        2194     2199       +5     
+ Partials       111      100      -11

Impacted Files	Coverage Δ
src/datastore/pg-store-event-emitter.ts	`100.00% <ø> (ø)`
src/event-stream/core-node-message.ts	`94.44% <ø> (ø)`
src/index.ts	`0.00% <ø> (ø)`
src/sample-data/broadcast-contract-default.ts	`100.00% <ø> (ø)`
src/shutdown-handler.ts	`0.00% <0.00%> (ø)`
src/token-metadata/tokens-contract-handler.ts	`84.21% <ø> (+0.87%)`	⬆️
src/token-metadata/tokens-processor-queue.ts	`86.74% <ø> (+2.23%)`	⬆️
src/event-stream/pox2-event-parsing.ts	`4.80% <4.80%> (ø)`
src/api/routes/debug.ts	`22.07% <18.66%> (+1.09%)`	⬆️
src/event-stream/reader.ts	`80.17% <53.84%> (-8.49%)`	⬇️
... and 97 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

coveralls · 2023-01-05T17:12:01Z

Coverage: 78.58%. Remained the same when pulling c024e5c on fix/btc-pox-ops into a512511 on develop.

rafaelcr

LGTM

…e 2.1 behavior

## [7.0.0-beta.1](v6.2.1...v7.0.0-beta.1) (2023-01-10) ### ⚠ BREAKING CHANGES * a sync from genesis is required to use with a Stacks v2.1-rc node ### Features * **agg-paging-limits:** aggregated all paging query limits ([#1401](#1401)) ([0203d36](0203d36)), closes [#1379](#1379) [#1379](#1379) * Stacks 2.1 support ([#1498](#1498)) ([dcbdfb9](dcbdfb9)), closes [#1279](#1279) [#1280](#1280) [#1283](#1283) [#1285](#1285) [#1289](#1289) [#1290](#1290) [#1295](#1295) [#1339](#1339) [#1363](#1363) [#1367](#1367) [#1372](#1372) [#1413](#1413) [#1449](#1449) [#1205](#1205) [#1197](#1197) [#1206](#1206) [#1179](#1179) [#1190](#1190) [#1167](#1167) [#1363](#1363) [#1193](#1193) [#1162](#1162) [#1216](#1216) [#1289](#1289) [#1290](#1290) [#1241](#1241) [#1168](#1168) [#1218](#1218) [#1339](#1339) [#1413](#1413) [#1283](#1283) [#1280](#1280) [#1285](#1285) [#1403](#1403) [#1456](#1456) [#1454](#1454) [#1454](#1454) [#1456](#1456) [#1403](#1403) [#1461](#1461) [#1476](#1476) [#1329](#1329) [#1287](#1287) [#1476](#1476) [#1366](#1366) [#1304](#1304) [#1331](#1331) [#1332](#1332) [#1379](#1379) [#1379](#1379) [#1355](#1355) [#1287](#1287) [#1389](#1389) [#1323](#1323) [#1368](#1368) [#1348](#1348) [#1314](#1314) [#1303](#1303) [#1425](#1425) [#1334](#1334) [#1309](#1309) [#1445](#1445) [#1374](#1374) [#1345](#1345) [#1353](#1353) [#1433](#1433) [#1424](#1424) [#1427](#1427) [#1301](#1301) [#1458](#1458) [#1379](#1379) [#1270](#1270) [#1324](#1324) [#1356](#1356) [#1360](#1360) [#1315](#1315) [#1326](#1326) [#1440](#1440) [#1351](#1351) [#1410](#1410) [#1337](#1337) [#1420](#1420) [#1328](#1328) [#1329](#1329) [#1343](#1343) [#1329](#1329) [#1495](#1495) ### Bug Fixes * add bnsImportUpdate to event emitter to fix BNS import test ([#1491](#1491)) ([2f9cb0c](2f9cb0c)) * guarantee db is empty before performing a replay ([#1374](#1374)) ([ef8e7a9](ef8e7a9)) * lint docs ci dependencies ([#1458](#1458)) ([90d0c7b](90d0c7b)) * make query limits backwards compatible ([#1509](#1509)) ([a0cebf5](a0cebf5)) * reorg txs by inserting txs that are missing from the mempool table ([#1429](#1429)) ([a512511](a512511)) * synthetic tx parsing for pox2 bitcoin-ops ([#1505](#1505)) ([720dc87](720dc87)) ### Miscellaneous Chores * support for Stacks 2.1 ([e88ec29](e88ec29))

blockstack-devops · 2023-01-10T18:53:20Z

🎉 This PR is included in version 7.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [7.0.0](v6.3.4...v7.0.0) (2023-02-07) ### ⚠ BREAKING CHANGES * support for upcoming Stacks 2.1 features, event-replay required; * a sync from genesis is required to use with a Stacks v2.1-rc node ### Features * [Stacks 2.1] `delegate-stx` Bitcoin-op parsing ([#1527](#1527)) ([ea01587](ea01587)) * **agg-paging-limits:** aggregated all paging query limits ([#1401](#1401)) ([0203d36](0203d36)), closes [#1379](#1379) [#1379](#1379) * Stacks 2.1 support ([#1498](#1498)) ([dcbdfb9](dcbdfb9)), closes [#1279](#1279) [#1280](#1280) [#1283](#1283) [#1285](#1285) [#1289](#1289) [#1290](#1290) [#1295](#1295) [#1339](#1339) [#1363](#1363) [#1367](#1367) [#1372](#1372) [#1413](#1413) [#1449](#1449) [#1205](#1205) [#1197](#1197) [#1206](#1206) [#1179](#1179) [#1190](#1190) [#1167](#1167) [#1363](#1363) [#1193](#1193) [#1162](#1162) [#1216](#1216) [#1289](#1289) [#1290](#1290) [#1241](#1241) [#1168](#1168) [#1218](#1218) [#1339](#1339) [#1413](#1413) [#1283](#1283) [#1280](#1280) [#1285](#1285) [#1403](#1403) [#1456](#1456) [#1454](#1454) [#1454](#1454) [#1456](#1456) [#1403](#1403) [#1461](#1461) [#1476](#1476) [#1329](#1329) [#1287](#1287) [#1476](#1476) [#1366](#1366) [#1304](#1304) [#1331](#1331) [#1332](#1332) [#1379](#1379) [#1379](#1379) [#1355](#1355) [#1287](#1287) [#1389](#1389) [#1323](#1323) [#1368](#1368) [#1348](#1348) [#1314](#1314) [#1303](#1303) [#1425](#1425) [#1334](#1334) [#1309](#1309) [#1445](#1445) [#1374](#1374) [#1345](#1345) [#1353](#1353) [#1433](#1433) [#1424](#1424) [#1427](#1427) [#1301](#1301) [#1458](#1458) [#1379](#1379) [#1270](#1270) [#1324](#1324) [#1356](#1356) [#1360](#1360) [#1315](#1315) [#1326](#1326) [#1440](#1440) [#1351](#1351) [#1410](#1410) [#1337](#1337) [#1420](#1420) [#1328](#1328) [#1329](#1329) [#1343](#1343) [#1329](#1329) [#1495](#1495) ### Bug Fixes * add bnsImportUpdate to event emitter to fix BNS import test ([#1491](#1491)) ([2f9cb0c](2f9cb0c)) * build rosetta with node 16 ([654b64f](654b64f)) * datastore tests ([bb96507](bb96507)) * guarantee db is empty before performing a replay ([#1374](#1374)) ([ef8e7a9](ef8e7a9)) * lint docs ci dependencies ([#1458](#1458)) ([90d0c7b](90d0c7b)) * make query limits backwards compatible ([#1509](#1509)) ([a0cebf5](a0cebf5)) * prevent token metadata processor from blocking api launch ([#1514](#1514)) ([63da7e1](63da7e1)) * reorg txs by inserting txs that are missing from the mempool table ([#1429](#1429)) ([a512511](a512511)) * synthetic tx parsing for pox2 bitcoin-ops ([#1505](#1505)) ([720dc87](720dc87)) * test tx types ([11b9013](11b9013)) * use correct `pox-addr` arg while parsing `stack-stx` bitcoin-op [#415](#415) ([#1533](#1533)) ([ab14ad5](ab14ad5)) * use pg bigint for `pox_v1_unlock_height` column ([#1521](#1521)) ([d3fd685](d3fd685)) ### Miscellaneous Chores * note for Stacks 2.1 support and major version bump ([d27f956](d27f956)) * support for Stacks 2.1 ([e88ec29](e88ec29))

blockstack-devops · 2023-02-07T19:40:51Z

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

chore: bump to stacks-node 2.1.0.0.0-rc1 working branch

a265c27

github-actions bot temporarily deployed to commit January 5, 2023 16:58 Inactive

github-actions bot temporarily deployed to pull request January 5, 2023 17:02 Inactive

test: integration test to reproduce StackStx Bitcoin-op error

d9e7345

github-actions bot temporarily deployed to commit January 9, 2023 19:56 Inactive

github-actions bot temporarily deployed to pull request January 9, 2023 19:57 Inactive

chore: cleanup btc tx construction

5db0f52

github-actions bot temporarily deployed to commit January 9, 2023 20:51 Inactive

github-actions bot temporarily deployed to pull request January 9, 2023 20:51 Inactive

fix: bug in parsing STX Operations on Bitcoin for Stacks 2.1

5f6df4f

github-actions bot temporarily deployed to commit January 9, 2023 21:17 Inactive

github-actions bot temporarily deployed to pull request January 9, 2023 21:18 Inactive

test: cleanup integration tests

a42e0c3

github-actions bot temporarily deployed to commit January 9, 2023 22:50 Inactive

github-actions bot temporarily deployed to pull request January 9, 2023 22:51 Inactive

ci: lint fixes

f009dee

zone117x marked this pull request as ready for review January 9, 2023 22:52

github-actions bot temporarily deployed to pull request January 9, 2023 22:54 Inactive

github-actions bot temporarily deployed to commit January 9, 2023 22:54 Inactive

chore: revert accidental debug config change

7caabcf

github-actions bot temporarily deployed to commit January 9, 2023 22:58 Inactive

github-actions bot temporarily deployed to pull request January 9, 2023 22:59 Inactive

chore: bump stacks-node image to version with btc wallet priv key config

be6a5a1

github-actions bot temporarily deployed to commit January 10, 2023 09:04 Inactive

github-actions bot temporarily deployed to pull request January 10, 2023 09:04 Inactive

test: ensure synthetic stx-stack tx obj is generated with correct values

915f229

github-actions bot temporarily deployed to pull request January 10, 2023 11:56 Inactive

github-actions bot temporarily deployed to commit January 10, 2023 11:57 Inactive

test: fix expected values in synthetic stack-stx tx test

e4e538f

github-actions bot temporarily deployed to commit January 10, 2023 12:28 Inactive

github-actions bot temporarily deployed to pull request January 10, 2023 12:29 Inactive

test: add test for delegate-stack burnchain op

4970302

zone117x requested review from janniks and rafaelcr January 10, 2023 13:39

github-actions bot temporarily deployed to commit January 10, 2023 13:40 Inactive

github-actions bot temporarily deployed to pull request January 10, 2023 13:42 Inactive

rafaelcr approved these changes Jan 10, 2023

View reviewed changes

fix: patches to pox-2 transition tests to work with latest stacks-nod…

c024e5c

…e 2.1 behavior

github-actions bot temporarily deployed to pull request January 10, 2023 15:39 Inactive

github-actions bot temporarily deployed to commit January 10, 2023 15:39 Inactive

zone117x merged commit 720dc87 into develop Jan 10, 2023

zone117x deleted the fix/btc-pox-ops branch January 10, 2023 16:15

blockstack-devops added the released on @beta label Jan 10, 2023

blockstack-devops added the released label Feb 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Stacks 2.1] fix: synthetic tx parsing for pox2 bitcoin-ops #1505

[Stacks 2.1] fix: synthetic tx parsing for pox2 bitcoin-ops #1505

Uh oh!

zone117x commented Jan 5, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jan 5, 2023 •

edited

Loading

Uh oh!

codecov-commenter commented Jan 5, 2023 •

edited

Loading

Uh oh!

coveralls commented Jan 5, 2023 •

edited

Loading

Uh oh!

rafaelcr left a comment

Uh oh!

blockstack-devops commented Jan 10, 2023

Uh oh!

blockstack-devops commented Feb 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[Stacks 2.1] fix: synthetic tx parsing for pox2 bitcoin-ops #1505

[Stacks 2.1] fix: synthetic tx parsing for pox2 bitcoin-ops #1505

Uh oh!

Conversation

zone117x commented Jan 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jan 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coveralls commented Jan 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rafaelcr left a comment

Choose a reason for hiding this comment

Uh oh!

blockstack-devops commented Jan 10, 2023

Uh oh!

blockstack-devops commented Feb 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zone117x commented Jan 5, 2023 •

edited

Loading

github-actions bot commented Jan 5, 2023 •

edited

Loading

codecov-commenter commented Jan 5, 2023 •

edited

Loading

coveralls commented Jan 5, 2023 •

edited

Loading