Skip to content

fix: use pg bigint for pox_v1_unlock_height column #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zone117x merged 3 commits into from
Jan 13, 2023
Merged

fix: use pg bigint for pox_v1_unlock_height column #1521

zone117x merged 3 commits into from
Jan 13, 2023

Conversation

@zone117x
Copy link
Contributor

@zone117x zone117x commented Jan 13, 2023

Fixes bug with the pox_v1_unlock_height pg column being too small (int32 vs int64)

Error report:

{"level":"error","message":"error processing core-node /new_block: PostgresError: value \"4294967285\" is out of range for type integer value \"4294967285\" is out of range for type integer","stack":"PostgresError: value \"4294967285\" is out of range for type integer\n    at ErrorResponse (/home/admin/stacks-blockchain-api/node_modules/postgres/cjs/src/connection.js:765:26)\n    at handle (/home/admin/stacks-blockchain-api/node_modules/postgres/cjs/src/connection.js:468:6)\n    at Socket.data (/home/admin/stacks-blockchain-api/node_modules/postgres/cjs/src/connection.js:312:9)\n    at Socket.emit (node:events:513:28)\n    at addChunk (node:internal/streams/readable:315:12)\n    at readableAddChunk (node:internal/streams/readable:289:9)\n    at Socket.Readable.push (node:internal/streams/readable:228:10)\n    at TCP.onStreamRead (node:internal/stream_base_commons:190:23)\n    at TCP.callbackTrampoline (node:internal/async_hooks:130:17)\n    at cachedError (/home/admin/stacks-blockchain-api/node_modules/postgres/cjs/src/query.js:171:23)\n    at new Query (/home/admin/stacks-blockchain-api/node_modules/postgres/cjs/src/query.js:36:24)\n    at sql (/home/admin/stacks-blockchain-api/node_modules/postgres/cjs/src/index.js:111:11)\n    at /home/admin/stacks-blockchain-api/src/datastore/pg-write-store.ts:357:18","timestamp":"2023-01-13T17:01:59.139Z"}
{"level":"error","message":"HTTP POST /new_block","req":{"headers":{"content-length":"1801","content-type":"application/json","host":"localhost:3700"},"httpVersion":"1.1","method":"POST","originalUrl":"/new_block","query":{},"url":"/new_block"},"res":{"statusCode":500},"responseTime":3,"timestamp":"2023-01-13T17:01:59.139Z"}

@zone117x zone117x requested a review from rafaelcr January 13, 2023 17:57
@github-actions github-actions bot temporarily deployed to commit January 13, 2023 17:58 Inactive
@github-actions
Copy link

github-actions bot commented Jan 13, 2023 •
edited
Loading

🚀 Deployed on https://deploy-preview-1521--stacks-blockchain-api.netlify.app

@github-actions github-actions bot temporarily deployed to pull request January 13, 2023 18:00 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023 •
edited by codecov bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions github-actions bot temporarily deployed to pull request January 13, 2023 18:03 Inactive
@github-actions github-actions bot temporarily deployed to commit January 13, 2023 18:04 Inactive
@github-actions github-actions bot temporarily deployed to commit January 13, 2023 18:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 13, 2023 18:18 Inactive
@zone117x zone117x merged commit d3fd685 into beta Jan 13, 2023
@zone117x zone117x deleted the fix/pg-schema-pox-state-int branch January 13, 2023 19:38
blockstack-devops pushed a commit that referenced this pull request Jan 13, 2023
@semantic-release-bot
chore(release): 7.0.0-beta.3 [skip ci]
b9109b8 
## [7.0.0-beta.3](v7.0.0-beta.2...v7.0.0-beta.3) (2023-01-13)

### Bug Fixes

* use pg bigint for `pox_v1_unlock_height` column ([#1521](#1521)) ([d3fd685](d3fd685))
@blockstack-devops
Copy link
Contributor

blockstack-devops commented Jan 13, 2023

🎉 This PR is included in version 7.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

blockstack-devops pushed a commit that referenced this pull request Feb 7, 2023
@semantic-release-bot
chore(release): 7.0.0 [skip ci]
65f72d3 
## [7.0.0](v6.3.4...v7.0.0) (2023-02-07)

### ⚠ BREAKING CHANGES

* support for upcoming Stacks 2.1 features, event-replay required;
* a sync from genesis is required to use with a Stacks v2.1-rc node

### Features

* [Stacks 2.1] `delegate-stx` Bitcoin-op parsing ([#1527](#1527)) ([ea01587](ea01587))
* **agg-paging-limits:** aggregated all paging query limits ([#1401](#1401)) ([0203d36](0203d36)), closes [#1379](#1379) [#1379](#1379)
* Stacks 2.1 support ([#1498](#1498)) ([dcbdfb9](dcbdfb9)), closes [#1279](#1279) [#1280](#1280) [#1283](#1283) [#1285](#1285) [#1289](#1289) [#1290](#1290) [#1295](#1295) [#1339](#1339) [#1363](#1363) [#1367](#1367) [#1372](#1372) [#1413](#1413) [#1449](#1449) [#1205](#1205) [#1197](#1197) [#1206](#1206) [#1179](#1179) [#1190](#1190) [#1167](#1167) [#1363](#1363) [#1193](#1193) [#1162](#1162) [#1216](#1216) [#1289](#1289) [#1290](#1290) [#1241](#1241) [#1168](#1168) [#1218](#1218) [#1339](#1339) [#1413](#1413) [#1283](#1283) [#1280](#1280) [#1285](#1285) [#1403](#1403) [#1456](#1456) [#1454](#1454) [#1454](#1454) [#1456](#1456) [#1403](#1403) [#1461](#1461) [#1476](#1476) [#1329](#1329) [#1287](#1287) [#1476](#1476) [#1366](#1366) [#1304](#1304) [#1331](#1331) [#1332](#1332) [#1379](#1379) [#1379](#1379) [#1355](#1355) [#1287](#1287) [#1389](#1389) [#1323](#1323) [#1368](#1368) [#1348](#1348) [#1314](#1314) [#1303](#1303) [#1425](#1425) [#1334](#1334) [#1309](#1309) [#1445](#1445) [#1374](#1374) [#1345](#1345) [#1353](#1353) [#1433](#1433) [#1424](#1424) [#1427](#1427) [#1301](#1301) [#1458](#1458) [#1379](#1379) [#1270](#1270) [#1324](#1324) [#1356](#1356) [#1360](#1360) [#1315](#1315) [#1326](#1326) [#1440](#1440) [#1351](#1351) [#1410](#1410) [#1337](#1337) [#1420](#1420) [#1328](#1328) [#1329](#1329) [#1343](#1343) [#1329](#1329) [#1495](#1495)

### Bug Fixes

* add bnsImportUpdate to event emitter to fix BNS import test ([#1491](#1491)) ([2f9cb0c](2f9cb0c))
* build rosetta with node 16 ([654b64f](654b64f))
* datastore tests ([bb96507](bb96507))
* guarantee db is empty before performing a replay ([#1374](#1374)) ([ef8e7a9](ef8e7a9))
* lint docs ci dependencies ([#1458](#1458)) ([90d0c7b](90d0c7b))
* make query limits backwards compatible ([#1509](#1509)) ([a0cebf5](a0cebf5))
* prevent token metadata processor from blocking api launch ([#1514](#1514)) ([63da7e1](63da7e1))
* reorg txs by inserting txs that are missing from the mempool table ([#1429](#1429)) ([a512511](a512511))
* synthetic tx parsing for pox2 bitcoin-ops ([#1505](#1505)) ([720dc87](720dc87))
* test tx types ([11b9013](11b9013))
* use correct `pox-addr` arg while parsing `stack-stx` bitcoin-op [#415](#415) ([#1533](#1533)) ([ab14ad5](ab14ad5))
* use pg bigint for `pox_v1_unlock_height` column ([#1521](#1521)) ([d3fd685](d3fd685))

### Miscellaneous Chores

* note for Stacks 2.1 support and major version bump ([d27f956](d27f956))
* support for Stacks 2.1 ([e88ec29](e88ec29))
@blockstack-devops
Copy link
Contributor

blockstack-devops commented Feb 7, 2023

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafaelcr rafaelcr rafaelcr approved these changes

Assignees

No one assigned

Labels

released on @beta released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zone117x @codecov-commenter @blockstack-devops @rafaelcr