Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Vite 6 #769

Open
4 tasks done
hugoattal opened this issue Nov 26, 2024 · 2 comments · May be fixed by #770
Open
4 tasks done

Update to Vite 6 #769

hugoattal opened this issue Nov 26, 2024 · 2 comments · May be fixed by #770
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed in progress

Comments

@hugoattal
Copy link
Collaborator

Clear and concise description of the problem

Update to Vite 6

Suggested solution

Update to Vite 6

Alternative

No response

Additional context

No response

Validations

@hugoattal hugoattal added the enhancement: to triage New feature of request pending review by team member label Nov 26, 2024
@hugoattal hugoattal self-assigned this Nov 26, 2024
@hugoattal hugoattal added enhancement New feature or request in progress and removed enhancement: to triage New feature of request pending review by team member labels Nov 26, 2024
@hugoattal hugoattal linked a pull request Nov 26, 2024 that will close this issue
4 tasks
@hugoattal hugoattal added the help wanted Extra attention is needed label Dec 10, 2024
@hugoattal
Copy link
Collaborator Author

hugoattal commented Dec 10, 2024

If someone has some knowledge with Vite 6 and vite-node, it would be super helpful if you could help me fix the issue with the PR... #770

If you run pnpm watch, then run the examples/vue3 package with pnpm run story:build, you'll see this error:

[ERR_MODULE_NOT_FOUND]: Cannot find package 'histoire-style' imported from C:\Users\hugoa\Documents\git\histoire\examples\vue3\node_modules\.histoire\plugins\builtin_tailwind-tokens\Tailwind.story.mjs

If you delete the histoire-style from tailwind-tokens.ts, you'll get this error:

[ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".css" for C:\Users\hugoa\Documents\git\histoire\examples\vue3\node_modules\.histoire\plugins\builtin_tailwind-tokens\style.css

The error arises from

await run({
file: payload.storyFile,
storyData,
el,
})

I have tested everything I could, but I can't seem to fix this issue. Histoire works without Tailwind, but it would be great to fix this problem. A huge refactoring may be needed to fix this, but I'd rather make it work with the current architecture if it's possible.

(cc @Akryum)

@hugoattal
Copy link
Collaborator Author

Well, it's likely due to a breaking change in vite-node from 0.37.7 to 1.0.0. I reverted the version, but it's pretty old, we should either find a way to make it work with recent version of ivte-node or using the new Vite environment runtime. I tried to use it but ran into the same kind of problem though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant