Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate includes files and example files / Add additional, visualized examples / Elaborate README.md #15

Merged
merged 9 commits into from
Dec 1, 2021

Conversation

LimHyungTae
Copy link
Contributor

@LimHyungTae LimHyungTae commented Nov 25, 2021

Dear @Ecstasy-EC:

Hello there Yixi, I'd like to do PR to your ikd-tree repository. Your fantastic method deserves to be nicer!

[Features]

  • Separate includes files and example files
  • Add two examples (Also, I follow your code format...In fact I hate your combination format of the Snake case and Pascal case lol)
    • In particular, the public function Search_Points_by_box is added. Please refer to codes.
  • Update README
    • In particular, build commands are added
    • Visualized results are added

As you're an HKUSTian, so I utilized livox-loam to get the Red Bird Sundial pcd file 😄

In addition, my large_scale_map.pcd is used for an example 3, i.e., the async example. I think this file can be substituted by any file. If you'd like to use this file, it would also be better to upload large_scale_map.pcd on your lab's official drive (e.g. Google drive). If then, please README.md appropriately!

Cheers~

@LimHyungTae LimHyungTae changed the title Develop Separate includes files and example files / Add additional, visualized examples / Elaborate README.md Nov 25, 2021
@Ecstasy-EC
Copy link
Member

Hello HyungTae,

Thanks for your great contributions! I have gone through your commits and all of them seem OK to be merged. I will make further tests and merge them next week before I upgrade the codes.

Btw, I am a HKUian but not HKUSTian though I am very very familiar with HKUST lol.

Cheers!

@Ecstasy-EC
Copy link
Member

Hey @LimHyungTae !
Your codes are running well and everything looks fine. But I got one question. What are the files in /.idea? I found them not related to any codes and everything works fine after deleting them. If they are not required by any codes, I will remove them before I merge your pull request.

@LimHyungTae
Copy link
Contributor Author

Oh, it is a kind of .vscode folder, which is not necessary to run codes. Please remove the '.idea'. Thank you bro I hope to see you at ICRA'22~~ :)

@Ecstasy-EC
Copy link
Member

@LimHyungTae
OK I got it. Gonna merge it tomorrow and move forward to the new version. Thanks a lot for your contributions bro!

And unfortunately, I won't appear in the ICRA 2022 since the ikd-tree was not submitted to it. It was integrated and submitted to a journal together with FAST-LIO2(link in my README). Anyway, best wishes to you and your research!

@Ecstasy-EC Ecstasy-EC merged commit add200d into hku-mars:main Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants