(BUG FIX) Catching SystemExit
s Independently from Generic Exception
s
#22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all Exceptions are caught and few, if any, are reraised. This prohibits any fatal exceptions from forcing a system exit. Essentially, we want to catch and reraise fatal errors (
SystemExit
s) independently from genericException
s like this:From:
To:
See equivalent issue in my fork: zhanwenchen#1