-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTSPO-18443: Initial json function add #694
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reespozzi
requested review from
hannah38,
ssian2 and
staceywilson
and removed request for
a team
October 22, 2024 16:06
JordanHoey96
approved these changes
Oct 23, 2024
JoshuaGlassKainos
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
https://tools.hmcts.net/jira/browse/DTSPO-18443
This work is to enable us to send a summary of auto-shutdown status in daily-checks, but this lives in another repo. By adding these all to json files, we can talk across repos and send a slack message in daily-checks as a pt2 to this work
They're currently being sent to an auto-shutdown channel, but the tech improvement ask was to condense this into daily checks so it's all in one place.
This PR adds a new function which, whenever a status update is usually sent, we are dropping this into a json file under /status
This process is idempotent, because there is a json ID lookup happening so that files are overwritten or appended where needed
This /status dir is wiped every evening so we can start fresh each day when the first auto-start effort runs.
At present, it commits to a branch to ensure it's working properly once merged, then it can be pointed to master for runs