Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-webpage bookmarks duplication problem #364

Open
Haze-sh opened this issue Aug 27, 2024 · 7 comments
Open

Non-webpage bookmarks duplication problem #364

Haze-sh opened this issue Aug 27, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@Haze-sh
Copy link

Haze-sh commented Aug 27, 2024

When adding links that contain non-webpage content (like pdfs or gifs) it gets duplicated in the database, I think this shouldn't be the expected behaviour

@MohamedBassem MohamedBassem added the feature request New feature or request label Aug 31, 2024
@kamtschatka
Copy link
Collaborator

I have added a gif and a pdf to hoarder and got only 1 entry. Please provide more information on what you are doing and where you are seeing a duplication

@Haze-sh
Copy link
Author

Haze-sh commented Sep 1, 2024

Sorry this wasn't really clear, I was importing a list of urls through the command line, when I reimport the same list again the pdfs and gifs get readded to hoarder again but webpages do not duplicate. And they are not searchable too.

@kamtschatka
Copy link
Collaborator

can you please explain exactly what are you doing?
I ran bookmarks add --link https://asdf.readthedocs.io/_/downloads/en/2.9.2/pdf/ and get the response alreadyExists: false.
then I run it again and get the response alreadyExists: true and the bookmark is not added again.

Which commands are you calling to get the duplication?

@Haze-sh
Copy link
Author

Haze-sh commented Oct 5, 2024

I can't replicate this with the same exact command above! I don't have a clue what could have been different at my machine.

@Haze-sh
Copy link
Author

Haze-sh commented Oct 5, 2024

For further clarification, the above command gives alreadyExists: false at every re-run.

@kamtschatka
Copy link
Collaborator

are you on the latest version (0.17.1)?
I have just rerun the test and I can't reproduce it. Maybe someone else can reproduce it, but I don't really understand why the same command would lead to different outcomes on our machines, as it is quite simple^^

@kamtschatka
Copy link
Collaborator

OK now I can reproduce it, if you wait long enough for it to completely crawl, then this happens. I will have a look

kamtschatka added a commit to kamtschatka/hoarder-app that referenced this issue Oct 5, 2024
also considering bookmarkAssets when deduplicating links
@kamtschatka kamtschatka added bug Something isn't working and removed feature request New feature or request labels Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants