Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"At least a doodle was found to be drawn outside of the image bounds." #37

Open
dbuscombe-usgs opened this issue Jun 17, 2022 · 1 comment

Comments

@dbuscombe-usgs
Copy link

I ran into this issue, which prevented me from segmenting. This is potentially an issue, given how clunky it is to delete doodles ...

Is it a problem for doodling outside the window? How can we get around this constraint? It is a nice feature of Dash-Doodler that one can label over the edges to ensure the pixels near the edge are labeled

If I uncomment th code block starting on this line ...
https://github.com/pyviz-topics/holodoodler/blob/70ec3078d7257a4c468bf6e35ef58fe5f7369416/doodler/components.py#L545

... and the code still ran fine, giving me a good output. So, is there a specific reason to prevent the user segmenting the image if doodles are outside the image?

@maximlt
Copy link
Collaborator

maximlt commented Jun 17, 2022

Hey Dan, I wasn't sure the segmentation algorithm handled that properly hence that defensive approach. As it seems it can cope with that well I'll just remove that guard, thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants