Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try/except get_extents without dimension and add kwargs to all get_extents #5872

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Aug 30, 2023

Handle all cases where get_extents does not support dimension. Furthermore, all get_extents now have **kwargs.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Merging #5872 (e0b1fac) into main (e3dee54) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #5872      +/-   ##
==========================================
- Coverage   88.36%   88.36%   -0.01%     
==========================================
  Files         310      310              
  Lines       63959    63960       +1     
==========================================
- Hits        56519    56516       -3     
- Misses       7440     7444       +4     
Flag Coverage Δ
ui-tests 23.40% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/plotting/bokeh/element.py 87.95% <33.33%> (-0.11%) ⬇️
holoviews/plotting/mpl/chart.py 64.07% <100.00%> (ø)
holoviews/plotting/mpl/heatmap.py 93.27% <100.00%> (ø)
holoviews/plotting/mpl/raster.py 77.77% <100.00%> (ø)
holoviews/plotting/mpl/sankey.py 77.19% <100.00%> (ø)
holoviews/plotting/plot.py 91.71% <100.00%> (ø)
holoviews/plotting/plotly/chart.py 95.09% <100.00%> (ø)
holoviews/plotting/plotly/tiles.py 89.13% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro merged commit 9d74f7e into main Sep 6, 2023
14 checks passed
@hoxbro hoxbro deleted the kwargs_get_extents branch September 6, 2023 07:38
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants