Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matplotlib pin #5895

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Matplotlib pin #5895

merged 3 commits into from
Sep 19, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 19, 2023

With the release of matplotlib 3.8, the following tests are failing see here.

FAILED holoviews/tests/operation/test_operation.py::OperationTests::test_image_contours - AssertionError: Contours not almost equal to 6 decimals
FAILED holoviews/tests/operation/test_operation.py::OperationTests::test_image_contours_filled - AssertionError: Dimension parameter 'range' mismatched: (2.25, 2.25) != (2,...
FAILED holoviews/tests/operation/test_operation.py::OperationTests::test_qmesh_contours - AssertionError: Contours not almost equal to 6 decimals
FAILED holoviews/tests/operation/test_operation.py::OperationTests::test_qmesh_curvilinear_contours - AssertionError: Contours not almost equal to 6 decimals
FAILED holoviews/tests/operation/test_operation.py::OperationTests::test_qmesh_curvilinear_edges_contours - AssertionError: Contours not almost equal to 6 decimals
FAILED holoviews/tests/operation/test_statsoperations.py::KDEOperationTests::test_bivariate_kde_contours_filled - AssertionError: 9 != 10
FAILED holoviews/tests/plotting/matplotlib/test_heatmapplot.py::TestHeatMapPlot::test_heatmap_invert_axes - AssertionError: Arrays not almost equal to 6 decimals
FAILED holoviews/tests/plotting/matplotlib/test_heatmapplot.py::TestHeatMapPlot::test_heatmap_invert_xaxis - AssertionError: Arrays not almost equal to 6 decimals
FAILED holoviews/tests/plotting/matplotlib/test_heatmapplot.py::TestHeatMapPlot::test_heatmap_invert_yaxis - AssertionError: Arrays not almost equal to 6 decimals
FAILED holoviews/tests/plotting/matplotlib/test_quadmeshplot.py::TestQuadMeshPlot::test_quadmesh_invert_axes - AssertionError: Arrays not almost equal to 6 decimals
FAILED holoviews/tests/plotting/matplotlib/test_quadmeshplot.py::TestQuadMeshPlot::test_quadmesh_nodata - AssertionError: Arrays not almost equal to 6 decimals
FAILED holoviews/tests/plotting/matplotlib/test_quadmeshplot.py::TestQuadMeshPlot::test_quadmesh_nodata_uint - AssertionError: Arrays not almost equal to 6 decimals

Also adding the following warning:

holoviews/tests/operation/test_operation.py::OperationTests::test_image_contours
holoviews/tests/operation/test_operation.py::OperationTests::test_image_contours_filled
holoviews/tests/operation/test_operation.py::OperationTests::test_qmesh_contours
holoviews/tests/operation/test_operation.py::OperationTests::test_qmesh_curvilinear_contours
holoviews/tests/operation/test_operation.py::OperationTests::test_qmesh_curvilinear_edges_contours
  /home/runner/work/holoviews/holoviews/holoviews/operation/element.py:609: MatplotlibDeprecationWarning: The collections attribute was deprecated in Matplotlib 3.8 and will be removed two minor releases later.
    for level, cset in zip(levels, contour_set.collections):

I will try to fix these tests later this week. But for now I will just pin.

@hoxbro hoxbro enabled auto-merge (squash) September 19, 2023 07:49
@hoxbro hoxbro mentioned this pull request Sep 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #5895 (1579783) into main (06d2b6d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5895   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files         312      312           
  Lines       64943    64943           
=======================================
  Hits        57412    57412           
  Misses       7531     7531           
Flag Coverage Δ
ui-tests 23.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro
Copy link
Member Author

hoxbro commented Sep 19, 2023

With the new dev release of 1.18, we no longer support py2js, which were used for {x,y}formatters when the input was a function. I have removed it for now in the notebook.

@hoxbro hoxbro merged commit 70e7d5a into main Sep 19, 2023
11 checks passed
@hoxbro hoxbro deleted the matplotlib_pin branch September 19, 2023 10:20
@hoxbro hoxbro mentioned this pull request Oct 3, 2023
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants