Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations #5915

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Remove deprecations #5915

merged 6 commits into from
Oct 16, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Oct 3, 2023

Continue work from #5776

Resolves #5327
Resolves #5517

I already needed to remove some of py2js in examples here: 1579783 in #5895

@hoxbro hoxbro added this to the 1.18.0 milestone Oct 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

Merging #5915 (f7817af) into main (912d520) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5915      +/-   ##
==========================================
+ Coverage   88.58%   88.67%   +0.09%     
==========================================
  Files         313      313              
  Lines       65066    64941     -125     
==========================================
- Hits        57636    57588      -48     
+ Misses       7430     7353      -77     
Flag Coverage Δ
ui-tests 23.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
holoviews/core/boundingregion.py 65.46% <ø> (+3.04%) ⬆️
holoviews/operation/datashader.py 84.04% <ø> (+0.18%) ⬆️
holoviews/plotting/bokeh/element.py 88.37% <ø> (+0.23%) ⬆️
holoviews/plotting/bokeh/util.py 68.90% <100.00%> (+2.09%) ⬆️
holoviews/tests/plotting/bokeh/test_elementplot.py 99.50% <100.00%> (+2.58%) ⬆️
holoviews/tests/plotting/test_plotutils.py 99.41% <ø> (+2.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good.

@hoxbro hoxbro merged commit e4f4350 into main Oct 16, 2023
11 checks passed
@hoxbro hoxbro deleted the remove_deprecations branch October 16, 2023 10:14
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants