Do not allow partial matches when updating OverlayPlot #5962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the longest time OverlayPlots tried to be smart and remappped dynamically created elements to subplots as long as they partially matched the plot spec. A plot spec consists of
(<element-type>, <group>, <label>, <ndoverlay-dims>)
. Remapping plots like this can be more efficient but may also cause significant issues because a plot created for one element may have a bunch of state that is not correct for the new element. In theory all this state could be updated but we never did a good job at this, resulting in a variety of issues, e.g. subplots would end up assigning the wrong colors, legend order or a variety of other incorrect properties to a glyph/renderer.Fixes: