Support dictionary cmaps for ImageStack #6025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6025 +/- ##
=======================================
Coverage 88.68% 88.69%
=======================================
Files 316 316
Lines 66032 66068 +36
=======================================
+ Hits 58562 58598 +36
Misses 7470 7470
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hoxbro
added
type: enhancement
jlstevens
reviewed
Dec 11, 2023
hoxbro
force-pushed
the
dict_cmap_imagestack
branch
from
e456d8f
to
1a77032
Compare
|
I think this is ready for review; tests failing because: |
ahuang11
force-pushed
the
dict_cmap_imagestack
branch
from
e2ff78d
to
6c91f6d
Compare
jlstevens
reviewed
Mar 20, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6012
I'm not sure if I'm a fan of the solution.