Improve groupby behavior for operation histogram #6172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6172 +/- ##
==========================================
+ Coverage 88.68% 88.70% +0.01%
==========================================
Files 316 316
Lines 66072 66117 +45
==========================================
+ Hits 58598 58649 +51
+ Misses 7474 7468 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hoxbro
commented
Apr 3, 2024
| @@ -754,6 +755,9 @@ class histogram(Operation): | |||
| groupby = param.ClassSelector(default=None, class_=(str, Dimension), doc=""" | |||
| Defines a dimension to group the Histogram returning an NdOverlay of Histograms.""") | |||
|
|
|||
| groupby_range = param.Selector(default="shared", objects=["shared", "separated"], doc=""" | |||
There was a problem hiding this comment.
Better names here are welcome.
philippjfr
approved these changes
Apr 5, 2024
philippjfr
reviewed
Apr 5, 2024
Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6170
Fixes #6171
TODO: