Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subcoordinates to be drawn from NdOverlay dimensions #6209

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 24, 2024

Resolves #6028

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (346be14) to head (95f2c25).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6209   +/-   ##
=======================================
  Coverage   88.52%   88.53%           
=======================================
  Files         323      323           
  Lines       67906    67932   +26     
=======================================
+ Hits        60116    60142   +26     
  Misses       7790     7790           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro added the type: enhancement Minor feature or improvement to an existing feature label May 17, 2024
@philippjfr
Copy link
Member Author

This should be good to merge. I will investigate whether adding support for subcoordinate groups drawn from the NdOverlay dimensions makes sense as a separate PR.

Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass and look like a relatively simple change.

@hoxbro hoxbro merged commit 4bd31bc into main Jun 7, 2024
14 checks passed
@hoxbro hoxbro deleted the subcoordinate_ndoverlay branch June 7, 2024 14:07
@droumis
Copy link
Member

droumis commented Jun 10, 2024

This doesn't seem to work for subcoordinate_y with the wide df example posted here

df = pd.read_csv('https://datasets.holoviz.org/stocks/v1/stocks.csv', parse_dates=['Date']).set_index('Date')

hv.NdOverlay({col: hv.Curve(df, 'Date', (col, 'Price')).opts(tools=['hover'], subcoordinate_y=True) for col in df.columns}, 'Ticker')
image

@droumis
Copy link
Member

droumis commented Jun 10, 2024

If I zoom out, the lines appear, so looks like a ranging issue.

Screen.Recording.2024-06-10.at.11.18.01.AM.mov

@philippjfr
Copy link
Member Author

Thanks, investigating.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support grabbing the label (and group?) for each subcoordinate_y plot from the NdOverlay key
3 participants