-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow subcoordinates to be drawn from NdOverlay dimensions #6209
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6209 +/- ##
=======================================
Coverage 88.52% 88.53%
=======================================
Files 323 323
Lines 67906 67932 +26
=======================================
+ Hits 60116 60142 +26
Misses 7790 7790 ☔ View full report in Codecov by Sentry. |
806a136
to
95f2c25
Compare
This should be good to merge. I will investigate whether adding support for subcoordinate groups drawn from the NdOverlay dimensions makes sense as a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass and look like a relatively simple change.
This doesn't seem to work for df = pd.read_csv('https://datasets.holoviz.org/stocks/v1/stocks.csv', parse_dates=['Date']).set_index('Date')
hv.NdOverlay({col: hv.Curve(df, 'Date', (col, 'Price')).opts(tools=['hover'], subcoordinate_y=True) for col in df.columns}, 'Ticker') |
If I zoom out, the lines appear, so looks like a ranging issue. Screen.Recording.2024-06-10.at.11.18.01.AM.mov |
Thanks, investigating. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Resolves #6028